Code Monkey home page Code Monkey logo

Comments (11)

TheTesla avatar TheTesla commented on August 16, 2024 2

#68 solves the problem, but we must reintroduce signature verification again later.

from omniauth_openid_connect.

stanhu avatar stanhu commented on August 16, 2024 1

I believe nov/json-jwt#92 is the proper fix for this issue.

from omniauth_openid_connect.

davidbasalla avatar davidbasalla commented on August 16, 2024

I also ran into this issue today, going to revert to 0.3.3 for now

from omniauth_openid_connect.

TheTesla avatar TheTesla commented on August 16, 2024

I think I found the problem:

::OpenIDConnect::ResponseObject::IdToken.decode(id_token, public_key)

public_key is an jwt encoded array of dicts, where each dict represents one key containing a key id. id_token is also an array of dicts. There must be the key id kid named in the id_token.

from omniauth_openid_connect.

gcolson avatar gcolson commented on August 16, 2024

Hi,

I just run into this same issue while using 0.3.3...
Does that makes sense to you ? Could it be not related to this issue ?
I have pretty much the same stacktrace as @tobiashuste

from omniauth_openid_connect.

TheTesla avatar TheTesla commented on August 16, 2024

Hi,

I just run into this same issue while using 0.3.3...
Does that makes sense to you ? Could it be not related to this issue ?
I have pretty much the same stacktrace as @tobiashuste

No, this must be something else. Is there an error "KidNotFound"?

from omniauth_openid_connect.

gcolson avatar gcolson commented on August 16, 2024

yep, same stacktrace as the one posted up there..

from omniauth_openid_connect.

stale avatar stale commented on August 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from omniauth_openid_connect.

maxbes avatar maxbes commented on August 16, 2024

We solved this issue on our Gitlab instance by switching the ID token signature method to RS256 instead of HS256 in our OP configuration.

It is normal for JWT signed with HS* to not have a kid because they are unambiguously signed by the client secret in the context of OpenID Connect. The lack of kid should not be a fatal error.

from omniauth_openid_connect.

stanhu avatar stanhu commented on August 16, 2024

Got some feedback from the json-jwt maintainer, and this is another attempt at fixing this issue: #91

from omniauth_openid_connect.

TomNaessens avatar TomNaessens commented on August 16, 2024

@stanhu Is the fix you provided for this issue in #91 or nov/json-jwt#92 expected to get merged & released? Both maintainers don't seem very willing nor active 😦
Should we switch to the Gitlab fork? In case of the latter, is there any Omniauth 2.x support planned for that fork?

from omniauth_openid_connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.