Code Monkey home page Code Monkey logo

Comments (8)

shreyakurian02 avatar shreyakurian02 commented on May 24, 2024 1

@BobbyMcWho I have opened a PR for the same. Please do check.

from omniauth.

BobbyMcWho avatar BobbyMcWho commented on May 24, 2024 1

I've released a fix for this in 2.1.1 which has been pushed to rubygems

from omniauth.

BobbyMcWho avatar BobbyMcWho commented on May 24, 2024

Do you have Omniauth.config.test_mode set?

from omniauth.

thisismydesign avatar thisismydesign commented on May 24, 2024

@BobbyMcWho yes, I got this error with both true and false

from omniauth.

BobbyMcWho avatar BobbyMcWho commented on May 24, 2024

The issue is that @env is nil, and actually lives in the Omniauth gem and not this one: https://github.com/omniauth/omniauth/blob/master/lib/omniauth/strategy.rb#L500-L502

We could return '' if @env is nil there, if you want to spin up a PR, I can take a look, else I'll get to it when I can find some time.

from omniauth.

thisismydesign avatar thisismydesign commented on May 24, 2024

@BobbyMcWho Thanks. This works in production though, so I'm wondering if there's a way to set env in the test as a workaround. But yeah env can be nil so it should be treated accordingly. I can provide a PR tomorrow

from omniauth.

jeremygottfried avatar jeremygottfried commented on May 24, 2024

Is there any workaround while we wait for the PR to be merged? I have the same issue with updating to 2.1.

from omniauth.

BobbyMcWho avatar BobbyMcWho commented on May 24, 2024

Hmm, actually I don't believe callback path is supposed to be called without an @env having been created

from omniauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.