Comments (8)
@BobbyMcWho I have opened a PR for the same. Please do check.
from omniauth.
I've released a fix for this in 2.1.1 which has been pushed to rubygems
from omniauth.
Do you have Omniauth.config.test_mode
set?
from omniauth.
@BobbyMcWho yes, I got this error with both true
and false
from omniauth.
The issue is that @env is nil, and actually lives in the Omniauth gem and not this one: https://github.com/omniauth/omniauth/blob/master/lib/omniauth/strategy.rb#L500-L502
We could return ''
if @env is nil there, if you want to spin up a PR, I can take a look, else I'll get to it when I can find some time.
from omniauth.
@BobbyMcWho Thanks. This works in production though, so I'm wondering if there's a way to set env in the test as a workaround. But yeah env can be nil so it should be treated accordingly. I can provide a PR tomorrow
from omniauth.
Is there any workaround while we wait for the PR to be merged? I have the same issue with updating to 2.1.
from omniauth.
Hmm, actually I don't believe callback path is supposed to be called without an @env having been created
from omniauth.
Related Issues (20)
- Really confused about implementation HOT 4
- How to configure OmniAuth::AuthenticityTokenProtection for Hanami HOT 1
- Loading strategies from database HOT 1
- Feature Request: sign in with Ethereum HOT 3
- Omniauth failed to detect the url -> Authentication passthru HOT 1
- Programatically invoke an omniauth strategy HOT 3
- `Rack::Builder#to_app` is not designed to be called for every request. HOT 18
- CSRF in Rack for callbacks requests
- Compatibility issues with rack-protection 3.x HOT 5
- Add Bake test for devise
- SSO Attlassian -> Gitlab (new user) HOT 1
- Memory leak possible HOT 2
- Allow customization of the login form? HOT 2
- Issues with oauth2 and doorkeeper on callback phase (invalid_request Missing required parameter: client_id) HOT 5
- Request phase - ActionController::InvalidAuthenticityToken even after skip_before_action HOT 1
- why user_response_structure's image have no effect HOT 2
- Need to update rack configuration from 2.2.3 to 2.2.3.1 HOT 1
- rack's executable "rackup" conflicts with rackup HOT 4
- Authentication failure! undefined method 'headers' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omniauth.