Code Monkey home page Code Monkey logo

Comments (4)

jamietanna avatar jamietanna commented on July 4, 2024

Actually maybe this isn't needed, and I may have thought it was needed due to #242

This may only be needed alongside #242 where a custom MarshalJSON is needed?

from go-jsonschema.

jamietanna avatar jamietanna commented on July 4, 2024

This could alternatively be a new Validator that handles the generation of

Example (Apache-2.0 licensed) code that's output from oapi-codegen for the same purpose:

func (a Pong) MarshalJSON() ([]byte, error) {
	var err error
	object := make(map[string]json.RawMessage)

	object["ping"], err = json.Marshal(a.Ping)
	if err != nil {
		return nil, fmt.Errorf("error marshaling 'ping': %w", err)
	}

	for fieldName, field := range a.AdditionalProperties {
		object[fieldName], err = json.Marshal(field)
		if err != nil {
			return nil, fmt.Errorf("error marshaling '%s': %w", fieldName, err)
		}
	}
	return json.Marshal(object)
}

For the following (OpenAPI):

    Pong:
      type: object
      required:
        - ping
      properties:
        ping:
          type: string
          example: pong
      additionalProperties:
        type: string

from go-jsonschema.

jamietanna avatar jamietanna commented on July 4, 2024

Alternatively could we conditionally generate a MarshalJSON method if we detect we have AdditionalProperties?

from go-jsonschema.

jamietanna avatar jamietanna commented on July 4, 2024

(This may also need tweaking for the unmarshalJSON implementation)

from go-jsonschema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.