Code Monkey home page Code Monkey logo

Comments (6)

olssonm avatar olssonm commented on June 14, 2024

@albrtogarcia Thanks for your feedback! I'll look into it ASAP โ€“ but yes, of course HTML should get rendered.

from ampersand.

olssonm avatar olssonm commented on June 14, 2024

@albrtogarcia Okay, ran some tests and I don't seem to be able to replicate the issue, for instance:

<a href="#">Test</a>

and even

<div>
    <div>
        Test
    </div>
</div>

(And Gruber's snippet) renders as it should. Do you have some example markdown that I can look into?

from ampersand.

albrtogarcia avatar albrtogarcia commented on June 14, 2024

Thank you so much @olssonm.

When I put this:

# Title

<div class="alert"><a href="https://www.docker.com/">Docker</a></div>

Lorem ipsum dolor sit amet, consectetetur adipispling elit sed do eiusm.

Only renders this:

<h1>Title</h1>
<p>Lorem ipsum dolor sit am et, consectet etur adipis cing el s sed do eiusm</p>

Now that I know that it should work I will run a test in a fresh Laravel install to discard conflicts with other packages.

I'll let you know the results.

Thank you again, best regards ๐Ÿ˜„

from ampersand.

olssonm avatar olssonm commented on June 14, 2024

@albrtogarcia How odd! The exact same snippet renders for me as it should:

Screenshot 2022-06-09 at 12 17 16

Do you know if you use and/or register league/commonmark anywhere else in your application? I can also take your version off league/commonmark in your composer.lock-file (technically my package olssonm/ampersand supports both 1.0 and 2.0, but that perhaps something changed during that version-bump โ€“ that's why I'm asking).

from ampersand.

albrtogarcia avatar albrtogarcia commented on June 14, 2024

Good news, in a fresh install works as expected.

Then weยดve looked for inconsistencies with other markdown related packages previously installed and we found that uninstalling graham-campbell/markdown package make yours work again. This package remained from a previous blog try.

In composer.lock we have league/[email protected].

Many thanks again @olssonm, I owe you a couple of beers ๐Ÿป (or whatever you like).

Have a nice day ๐Ÿ‘‹

from ampersand.

olssonm avatar olssonm commented on June 14, 2024

Gotcha. For future reference; looks like there was a clash with graham-campbell/markdown. In that package's settings the default is:

'html_input' = 'strip'

Which somehow "bleeds over" to olssonm/ampersand.

Will look into isolating this in the future.

from ampersand.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.