Code Monkey home page Code Monkey logo

Comments (6)

RascalTwo avatar RascalTwo commented on May 4, 2024 1

Regular yellow is already being used, see the captive being unbound. Figured you wanted to have as many elements uniquely coloured.


Having the health bright red should be better, I'll make the PR tomorrow.

from warriorjs.

olistic avatar olistic commented on May 4, 2024 1

@RascalTwo I'm going to update the GIF later, but I already added a screenshot to the homepage that shows your change!

from warriorjs.

RascalTwo avatar RascalTwo commented on May 4, 2024

What color would you like the score line to be?

bright-yellow-warrior-score

Bright Yellow looks good to me.

from warriorjs.

olistic avatar olistic commented on May 4, 2024

I like it! My only concern is that it looks like if it was more important than the health... Maybe regular yellow, or making the health bright red? BTW, feel free to open a PR at this point.

from warriorjs.

RascalTwo avatar RascalTwo commented on May 4, 2024

The bright red looks perfect.


I only added score to the .toJSON() method of the Warrior, since - for now at least - only the Warrior needs it's score at the moment.


I think the only documentation that needs updating due to the change is the Preview .gif. on the README.md

If you could tell me what color scheme is being used, I can update it. (I'm also a user of VSCode)

Or, another issue could be created to have the .gif updated at a later date, up to you.

from warriorjs.

olistic avatar olistic commented on May 4, 2024

Thanks @RascalTwo!

I think the only documentation that needs updating due to the change is the Preview .gif. on the README.md

Good call. Don't worry about it, I will update it later! (The color scheme is Nord, if you're still curious.)

from warriorjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.