Comments (6)
Regular yellow is already being used, see the captive being unbound. Figured you wanted to have as many elements uniquely coloured.
Having the health bright red should be better, I'll make the PR tomorrow.
from warriorjs.
@RascalTwo I'm going to update the GIF later, but I already added a screenshot to the homepage that shows your change!
from warriorjs.
What color would you like the score line to be?
Bright Yellow looks good to me.
from warriorjs.
I like it! My only concern is that it looks like if it was more important than the health... Maybe regular yellow, or making the health bright red? BTW, feel free to open a PR at this point.
from warriorjs.
The bright red looks perfect.
I only added score
to the .toJSON()
method of the Warrior
, since - for now at least - only the Warrior
needs it's score
at the moment.
I think the only documentation that needs updating due to the change is the Preview .gif
. on the README.md
If you could tell me what color scheme is being used, I can update it. (I'm also a user of VSCode)
Or, another issue could be created to have the .gif
updated at a later date, up to you.
from warriorjs.
Thanks @RascalTwo!
I think the only documentation that needs updating due to the change is the Preview
.gif
. on theREADME.md
Good call. Don't worry about it, I will update it later! (The color scheme is Nord, if you're still curious.)
from warriorjs.
Related Issues (20)
- Any plans on i18n? HOT 1
- Documentation links are broken in many places HOT 1
- access to newer abilities in previous levels HOT 3
- Connect WarriorJS CLI with warriorjs.com HOT 2
- Add ability to get warrior's max health HOT 3
- brief description on each release HOT 3
- @warriorjs/tower-tick-tick-boom warrior haven't got the "pivot" ability and bashing 'backward' forcedly
- Should the warrior receive more damage when attacked from behind? HOT 1
- Add retro sounds HOT 2
- translate Korean HOT 2
- Korean Translation HOT 3
- Can't access functions from a Unit object
- Watch for Player.js changes and run
- I cannot sign in or create an account for the online platform HOT 2
- When I 'Run' the game after defeated, the state isn't refreshed unless I reload the page for several times HOT 1
- rescue('backward') is undefined HOT 3
- This code is wierdly running HOT 4
- where did constructor() come from and what is it? How does it work and what does it mean? I'm not able to learn anything here HOT 1
- Error: No files matching the pattern "packages/**/src" were found
- Please help me with the algorithm of moves leading to victory in this 9th level on the map "Tick, Tick... Boom!"!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from warriorjs.