Code Monkey home page Code Monkey logo

Comments (3)

olegskl avatar olegskl commented on June 14, 2024

Investigating.

from gulp-stylelint.

olegskl avatar olegskl commented on June 14, 2024

I've run a test case locally and failAfterError does cause the task to fail with non-zero code on error.

After looking at your code I noticed that you're using gulp-plumber. It captures the error emitted by gulp-stylelint, logs it to console and ends the stream. So the actual error is caught but not re-thrown, thus you don't get a non-zero error code.

I'm not an expert in best practices on writing pipes, but this is not a long-running task, so you could add a process.exit(1); just after this.emit('end'); in your error handler.

from gulp-stylelint.

MrFirthy avatar MrFirthy commented on June 14, 2024

@olegskl Yes you are absolutely right. Having removed gulp-plumber from the task, failAfterError exits with the correct error code. Sorry to waste your time, thanks for looking into it 👍

from gulp-stylelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.