[BUG] Linting not working properly after 1.0.5 in CDN about graphiql-workspace HOT 8 CLOSED

Just published https://github.com/OlegIlyenko/graphiql-workspace/releases/tag/v1.1.1 I think it should fix the issue. Important: in my tests, only this combination of dependency version actually worked:

"dependencies": {
  // ...
  "graphiql-workspace": "1.1.1",
  "graphiql": "^0.11.5",
  "graphql": "^0.10.0"
},

I removed the dependency on graphiql-subscriptions-fetcher since the project is quite outdated and it does not look like it is maintained. Moreover, it exports just one small function which I just copy/pasted in this project.

The dependency (especially transitive dependency) version management in npm/yarn is quite a mess. graphql-js is one of the few libs that actually makes an explicit check for different versions. If there is a small mismatch in transitive versions, it will throw these errors :(

All that said, I am very very far from being an expert in npm dependency management. I would really appreciate a review from somebody who is more experienced in this area. In particular this change: 6258979#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

from graphiql-workspace.

Thanks @OlegIlyenko for taking a stab at this.

Looking at the change you mentioned, I am a bit surprised that the peer dependency on graphql is targeting 0.11.x while you are saying above that you actually need graphql 0.10.X.

Wouldn't this lead to npm / yarn complaining that the peer dependency is not met ?

from graphiql-workspace.

I tried 1.1.1 but it did not fix the issue for me, the same error is thrown with the same action. These are the dependencies I'm using

<link rel="stylesheet" media="screen" href="//maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css">
<link rel="stylesheet" media="screen" href="//cdnjs.cloudflare.com/ajax/libs/graphiql/0.9.3/graphiql.min.css">
<link rel="stylesheet" media="screen" href="//cdn.jsdelivr.net/npm/[email protected]/graphiql-workspace.css">

<script src="//cdn.jsdelivr.net/react/15.4.2/react.min.js"></script>
<script src="//cdn.jsdelivr.net/react/15.4.2/react-dom.min.js"></script>
<script src="//cdn.jsdelivr.net/npm/[email protected]/graphiql-workspace.min.js"></script>

from graphiql-workspace.

Hi @p4bloch , this does not seem to match the working combination of dependencies that @OlegIlyenko outlined above ([email protected] vs [email protected])

from graphiql-workspace.

Hey @tlvenn! Actually that's just the css, the graphiql version is included in the minified dist file. Anyway, I tried changing the CSS to match the bundled graphiql version but it did not change the outcome.

from graphiql-workspace.

oups my bad... I will try to look into it soon as well.

from graphiql-workspace.

Sorry it took so long to get back to this issue, I have submitted a PR to fix it for good.

from graphiql-workspace.

@OlegIlyenko any chance you can merge my PR and cut a release please ? Thanks in advance.

Right now 1.1.2 is broken as it still bundles 2 versions of graphql.

from graphiql-workspace.