Failure message color in pytest-html ? about pytest-check HOT 13 CLOSED

Those look like two totally different results to me, and it's not clear if they should both be colored the same or not. Can you provide the test that resulted in this? Or reproduce with a different test? I can provide you with sample tests that give all the different outcomes if you like.

from pytest-check.

@jeffwright13 Yes, sure. It's easily reproducing. Below comparing outputs from classic assert, pytest-assume and pytest-check and all results exported to pytest-html with next args:

--html=report.html --self-contained-html

from pytest_assume.plugin import assume
from pytest_check import check


def test_assert():
    assert 2 < 1, 'some message'

def test_assume():
    with assume: assert 2 < 1, 'some message'

def test_check():
    with check: assert 2 < 1, 'some message'

in html we see that classic assert and pytest-assume have classic red color in AssertionError message, except of pytest-check

from pytest-check.

Oh, I see what you are saying now. I didn't pick up on the fact that you're using different plugins, each of which changes the output in some way.

I'm sure @okken is more than capable of figuring out the issue, so I will just watch from the sidelines. I'd take a stab at it myself, but it does take time to assimilate someone else's code, and I'm not super familiar with this plugin.

from pytest-check.

I'm open to consider PRs for the change.

from pytest-check.

This is a good idea.
working on a solution.

from pytest-check.

color added in #94

from pytest-check.

I haven't checked the html output

from pytest-check.

My changes don't help any with the html output from pytest-html.

from pytest-check.

I actually think I made things worse for pytest-html.
So if using pytest-html, I recommend --color=no until we get this sorted out.

from pytest-check.

This makes me curious about how my plugin will handle this situation. I'll give it a test.

from pytest-check.

probably pushing to main today

from pytest-check.

This would require digging into pytest-html, maybe, which I'm not interested in doing at this time.

from pytest-check.

Closing for now. Feel free to bring up the issue again if you've got any thoughts on how to implement it.

from pytest-check.