Code Monkey home page Code Monkey logo

Comments (10)

HaykoKoryun avatar HaykoKoryun commented on August 20, 2024 1

I think it would be fairly simple to implement. One option from a cursory look is to modify the setMusic function to be polymorphic so that if an actual Audio object is passed instead of a String it uses the existing Audio object.

from rythm.js.

harrykc avatar harrykc commented on August 20, 2024 1

I found the reason, when the song replay, this issue will be happened

2017-02-24_221753

and i found this article http://stackoverflow.com/questions/35492397/remove-createmediaelementsource
any idea?

from rythm.js.

Okazari avatar Okazari commented on August 20, 2024

I'm currently working on a new API method for Rythm.js that can use an AudioElement instead of a String this one will just read audio and not control it.

from rythm.js.

Okazari avatar Okazari commented on August 20, 2024

Got a solution that works, going to clean the code and push it :)

from rythm.js.

Okazari avatar Okazari commented on August 20, 2024

You will be able to works with APlayer by doing this :

rythm.connectExternalAudioElement(ap.audio)
rythm.start();

Will be shipped in v1.2.4 (today)

from rythm.js.

harrykc avatar harrykc commented on August 20, 2024

This is awesome, its working, thanks for your great work.

from rythm.js.

Okazari avatar Okazari commented on August 20, 2024

You're welcome ! 😄

from rythm.js.

harrykc avatar harrykc commented on August 20, 2024

I found a strange issue, the animation will stop after few songs played(do not know how many, i have not count it). In APlayer, i am doing following code in play event.

ap.on('play', function() {
    rythm.connectExternalAudioElement(ap.audio);
    rythm.start();
})

I am debuging with it, but still no idea how to trigger it.

from rythm.js.

Okazari avatar Okazari commented on August 20, 2024

Thx for the feedback ! Did you had this issue more that once ?

Sometimes the preconfigured classes won't react on some songs. (Songs that don't use this frequencies)

from rythm.js.

harrykc avatar harrykc commented on August 20, 2024

Once trigger this issue, then the animation will stop, even for the next, next song.

from rythm.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.