osc52.copy_visual is copying one more character than selected about nvim-osc52 HOT 7 CLOSED

Btw, I just tested vim-oscyank and it doesn't have that issue!

The way I mapped it there:

xnoremap <C-c> :OSCYank<CR>

from nvim-osc52.

Does it happen with konsole only? Also, what is the value of your selection option (:set selection?)?

from nvim-osc52.

:set selection shows selection=exclusive.

Here is my config:

set selection=exclusive
set virtualedit=block,onemore

I think I tried it in kitty, but there it's even more broken overall, so I didn't dig much into that.

May be virtualedit setting affects it?

from nvim-osc52.

On my side it works as expected with your settings. Can you try with set selection=inclusive and see if it works?

from nvim-osc52.

With inclusive it actually works correctly.

So I think what happens, with exclusive it ignores the selection length and copies from the beginning of the selection to the current position of the cursor including it, even though the latter isn't selected (becasue of exclusive setting). So that produces one character more than needed.

from nvim-osc52.

I see the code doing this:

  -- Retrieve text
  vim.go.clipboard = ''
  vim.go.selection = 'inclusive'
  local command = fmt('keepjumps normal! %s', commands[mode][type])
  vim.cmd(fmt('silent execute "%s"', command))
  local text = vim.fn.getreg('"')

  -- Restore user settings
  vim.go.clipboard = clipboard
  vim.go.selection = selection

This looks like it ignores it whether selection setting was exclusive and treats everything as inclusive?

from nvim-osc52.

Yeah, just confirmed it. Commenting out vim.go.selection = 'inclusive' makes it work correctly for me!

So I think the code should make a distinction whether selection was exclusive or not with some check.

from nvim-osc52.