Code Monkey home page Code Monkey logo

Comments (5)

ohler55 avatar ohler55 commented on June 13, 2024 1

It is wrong, I agree. The buffer is reused but for Marshal it should make a copy before returning. The Writer.MustJSON suffers the same although I might take a different approach with that one and add an optional argument to either copy or not since in many case reuse of the buffer is not an issue. It certainly is with your use case.

I'll get the fix in tonight.

from ojg.

ohler55 avatar ohler55 commented on June 13, 2024 1

Thanks. I did create a unit test for it and verified it failed before the fix and not after.

from ojg.

ohler55 avatar ohler55 commented on June 13, 2024

Fixed and released as v1.14.3.

from ojg.

ohler55 avatar ohler55 commented on June 13, 2024

Thanks for letting me know.

from ojg.

Bios-Marcel avatar Bios-Marcel commented on June 13, 2024

I'll just close this. I'll trust that you've fixed this ^^

I just evaluated the library for a new project, meaning I won't test it again for now.

from ojg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.