Can't build on 32-bit CPU about ojg HOT 9 CLOSED

Thanks for the find. I would not have expected that since the documentation makes no mention of the restriction. I'll take a look at what the best work around is.

from ojg.

Please try the "32-bit" branch.

from ojg.

Yes, 32-bit branch seems fine, thanks!

from ojg.

Yep, agree – this is not obvious at all. One important thing I just realized is that math.MaxInt was only added in Go 1.17, so relying on it will make it impossible to build ojg on Go < 1.17.

from ojg.

The MaxInt64 is meant to be the limit on and array length for filters. I suspect no one could reasonably complain about a maximum of 21474836487.

from ojg.

The develop branch has what I hope is a fix.

from ojg.

v1.12.6 released with the fix.

from ojg.

@ohler55 thanks!

Just checked it out: 21474836487 is still larger than 2147483647 which is a maximum value for int32, so there are still errors:

❯ GOOS=linux GOARCH=arm go build
# github.com/ohler55/ojg/jp
../../jp/get.go:420:8: constant 21474836487 overflows int
../../jp/get.go:981:8: constant 21474836487 overflows int
../../jp/node.go:262:8: constant 21474836487 overflows int
../../jp/node.go:537:8: constant 21474836487 overflows int
../../jp/parse.go:355:13: constant 21474836487 overflows int
../../jp/parse.go:362:13: constant 21474836487 overflows int
../../jp/slice.go:27:10: constant 21474836487 overflows int

Looks like a typo in a number - maybe using math.MaxInt32 will be better here?

from ojg.

Typo, darn. I'll try again.

from ojg.