Comments (4)
cannawen
commented on June 14, 2024
I imagine something like #123 would fix it (not tested, I wasn't able to get the app to compile lol).
Looking at the code though, I think it would make sense to factor out the nextControl/previousControl into its own component. Then you can pass it props for:
- if it's enabled
- left or right navigation
and it might make the code easier to reason with. And it can also be reused for other pages (Heros and Matches)
from mobile.
cannawen
commented on June 14, 2024
Tested the fix on iOS sim (wasn't compiling on Android for whatever reason), looks ok. There's probably a similar issue with <20 matches though.
from mobile.
Proyoyo
commented on June 14, 2024
@cannawen Merged. Do you want to create a new issue for the nextControl/previousControl refactoring? The same issue exist on Matches page as well.
from mobile.
cannawen
commented on June 14, 2024
I'll create some new issues.
from mobile.
Related Issues (20)
- package-lock.json and yarn.lock HOT 3
- Matches page shows "next" button even when user has <20 matches
- Refactor page controls to be a separate component
- When going to next page, screen should scroll back to top HOT 9
- When viewing someone else's profile, page number should reset to 1
- Cannot navigate to Peers 2 levels deep
- Add mobile to reactnative.gallery 🎨
- Can't tab out of matches tab. HOT 1
- Attempting to navigate from page 4 of heroes to page 5 of heroes causes the app to crash. HOT 4
- Show match result (win/lose) in the home page using border to hero portraits
- Dark font hard to read on dark backgrounds HOT 1
- About ios jump url after steam authorize success HOT 5
- Rank supports 7 star system but app only supports 5 HOT 4
- update dotaconstants to latest HOT 1
- Update buildscript.ext.googlePlayServicesVersion to lockdown to a specific version HOT 2
- iPhone XS Max support
- Can't navigate again after visiting Favorites HOT 3
- Can't to use button 'Search Matches' in matches' tab
- mobile language feature request HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mobile.