om_account_asset: Assets are created each time a Vendor Bill goes through the process Confirm/Reset to Draft/Confirm about odooapps HOT 7 CLOSED

In om_account_asset/models/account_move.py we can override move_id's button_draft method to look for assets created by the move and then unlink them (see code below). But the asset.unlink method will only allow an asset to be deleted if the asset is in 'draft' state. It's possible that some or all of the assets created by the move are not in 'draft' state.

My question is: what should the business logic be? As written below, if any of the assets created by the invoice or bill have a state != 'draft', the following would result:

1. none of the assets would be deleted (even the ones that are in 'draft' state),
2. a UserError is raised such that the invoice or bill would not actually be changed to the draft state.

It would then be up to the user to address the situation as best they can. I'm not sure this is the best solution though. Other business logic options are:

1. Instead of trying to unlink the assets, we merely inform the user that there exists assets that were created by the move that they just deleted.
2. We delete any assets that are in 'draft' state and inform the user that there were other assets that could not be handled.
3. We disallow setting an invoice/bill back to draft (I'm not a fan of this option).

Thoughts? Thank you,
Ken

om_account_asset/models/account_move.py

def button_draft(self):
    # we want to do the native button_draft function steps first to give it a chance to error-out before our steps
    res = super(AccountMove, self).button_draft()

    for move in self:
        if move.state == 'draft':
            # the invoice was successfully set to draft state, therefore delete assets created by this move
            move_assets = self.env["account.asset.asset"].search([("invoice_id", "=", move.id)])
            move_assets.unlink()

    return True

from odooapps.

Thanks for reporting the issues, we will look at the issues and will get back to you.

from odooapps.

How about keeping the assets as inactive instead of deleting them ? Upon checking v11, seems instead of deleting, records are set to active False.

def button_draft(self):
res = super(AccountMove, self).button_draft()
for move in self:
if move.state == 'draft':
self.env['account.asset.asset'].search(
[('invoice_id', 'in', self.ids)]).write({'active': False})
return res

Your thoughts ? @kwoychesko

from odooapps.

I think setting active to False is a better idea than deleting the asset--great idea! We could even add a message to the chatter about why.

Unfortunately we still have the problem of duplicate assets being created if any of the assets were already approved.

from odooapps.

one more enhancement is added related to this, validation error will be shown now upon resetting the invoice when there is a asset in non drafted state.
See: a7531b7

from odooapps.

updated: a7531b7

can you review and shall we close this ?

from odooapps.

Looks great! Thanks!

from odooapps.