Code Monkey home page Code Monkey logo

Comments (3)

mwojcikowski avatar mwojcikowski commented on May 27, 2024

Thanks for this detailed explanation - now I clearly see what is wrong. The pi_stacking returns ring_dict instead of atom_dict (which is intentional). During the switch from resnum to resid in RDKit we forgot to change the ring_dict structure to have both.

I will fix that issue (i.e. add rings['resnum']), but for now you can take advantage of resid to get resnum. resid is a 0-based index, thus you have to use it to subset mol.res_dict:

rings, _, strict_parallel, strict_perpendicular = pi_stacking(protein, ligand)
mol.res_dict[rings['resid']]['resnum']

from oddt.

fabricecarles avatar fabricecarles commented on May 27, 2024

Thanks !
Are you planning to deploy this update in your anaconda channel soon?
Otherwise I will compile it ;)

Fabrice

from oddt.

mwojcikowski avatar mwojcikowski commented on May 27, 2024

I have identified a small bug which was found along adding resnum. If all tests pass the PR will be merged hopefully today/tomorrow. Regarding next release, I had no such plans for pushing another one, although you can expect it to land around the middle of June.

from oddt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.