Code Monkey home page Code Monkey logo

auth-basic.js's People

Contributors

charlietharas avatar dependabot[bot] avatar github-actions[bot] avatar gr2m avatar greenkeeper[bot] avatar prettier-toc-me[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

auth-basic.js's Issues

An in-range update of @octokit/request is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency @octokit/request was updated from 5.4.0 to 5.4.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@octokit/request is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ test (13): There are 1 failures, 0 warnings, and 0 notices.
  • ❌ test (12): There are 2 failures, 0 warnings, and 0 notices.
  • ❌ test (10): There are 2 failures, 0 warnings, and 0 notices.

Release Notes for v5.4.1

5.4.1 (2020-04-19)

Bug Fixes

  • deps: update @octokit/types to version 2.11.1 (#126) (ba043c3)
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @octokit/request is breaking the build 🚨

The dependency @octokit/request was updated from 5.2.1 to 5.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@octokit/request is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for v5.3.0

5.3.0 (2019-10-24)

Features

  • better Typescript definitions via @octokit/types (d868a31)
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @octokit/request-error is breaking the build 🚨

The dependency @octokit/request-error was updated from 1.2.0 to 1.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@octokit/request-error is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for v1.2.1

1.2.1 (2020-01-30)

Bug Fixes

  • package.json built by latest pika version (0.8.1) (346b69a)
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of prettier is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The devDependency prettier was updated from 2.0.2 to 2.0.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ test (13): There are 2 failures, 0 warnings, and 0 notices.
  • ❌ test (12): There are 2 failures, 0 warnings, and 0 notices.
  • βœ… update_prettier: There are 0 failures, 1 warnings, and 0 notices.
  • ❌ test (10): There are 1 failures, 0 warnings, and 0 notices.

Release Notes for 2.0.3

πŸ”— Changelog

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

The automated release is failing 🚨

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this πŸ’ͺ.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.


Cannot push to the Git repository.

semantic-release cannot push the version tag to the branch master on the remote Git repository with URL https://x-access-token:[secure]@github.com/octokit/auth-basic.js.

This can be caused by:


Good luck with your project ✨

Your semantic-release bot πŸ“¦πŸš€

πŸ€” How to implement request retries in case of an expired 2FA code

The current flow using all Octokit auth libraries is as follows.

1. Require the auth strategy method

Example

import { createBasicAuth } from "@octokit/auth-basic";

2. Create async auth method

Example

const auth = createBasicAuth({
  username: "octocat",
  password: "secret",
  on2Fa() {
    return prompt("2Fa Code");
  }
});

3. Use the auth method to retrieve authentication options before a request

Example

const authentication = await auth({ url: "/authorizations" });
const { data } = await request("/authorizations", {
  headers: authentication.headers
});

The challenge is: how to make sure that the request() call has all required authentications, included a 2Fa code?

With the current implementation await auth({url: '/authorizations'}) directly returns username and password and returns headers.authorization set to Basic <encoded username:password>. So if the user has 2Fa enabled, the request would fail with 401 Unauthorized and the user would need to catch the error, ask the user for a 2Fa code and retry the same request.

An alternative approach would be to always send a request to assure that the authentication is still valid. For basic auth, instead of just returning the username/password synchronously, a request could be sent to check if the user has 2Fa enabled, in which case the user would be prompted and the returned authentication would include the 2Fa code and x-github-otp header. But that approach has its own tradeoffs:

  1. Extra requests would need to be sent which would not be required for accounts that don’t have 2Fa enabled
  2. A 2Fa code expires, which means a 401 Unauthorized response would still need to be handled by re-requesting a 2Fa code from the user with some custom code

Yet another approach could mean that the async auth() has an additional auth.wrap(request, options) method which could directly be passed to @octokit/request as request.hook option. That would make it possible to catch & handle request errors. This would imply that all @octokit/auth-* libraries would need to return the auth.wrap(request, options) method, it could act as a replacement of the .headers and .query keys.

The last consideration is that if a user has 2Fa enabled with SMS then an SMS is only sent for one of the following routes

So if the user requests GET /authorizations and the server responses with 401 Unauthorized, then the user will not retrieve a 2Fa code if they have SMS configured as delivery.

I'm currently double checking that assumption.

Update

I can confirm that all these routes can be used to trigger an SMS for accounts that have 2Fa enabled:

  • {POST,PATCH,PUT} /authorizations
  • {POST,PATCH,PUT} /authorizations/:authorization_id (authorization_id can be bogus, e.g. POST /authorizations/1 will work)
  • {POST,PATCH,PUT} /authorizations/clients/:client_id/:fingerprint (client_id and fingerprint can be bogus, e.g. POST /authorizations/clients/1/1 works)

All above routes works, even though the following are not even valid routes and will return 404 when a valid OTP is passed

  • {PATCH,PUT} /authorizations
  • POST /authorizations/clients/:client_id
  • POST /authorizations/:authorization_id
  • POST /authorizations/clients/:client_id/:fingerprint

I can also confirm that the above path’s won’t work with GET, HEAD, or DELETE methods. I tested

  • GET /authorizations
  • DELETE /authorizations/:authorization_id

An in-range update of @octokit/request is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency @octokit/request was updated from 5.4.1 to 5.4.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@octokit/request is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ test (13): There are 2 failures, 0 warnings, and 0 notices.
  • ❌ test (12): There are 2 failures, 0 warnings, and 0 notices.
  • ❌ test (10): There are 1 failures, 0 warnings, and 0 notices.

Release Notes for v5.4.2

5.4.2 (2020-04-19)

Bug Fixes

  • update to @octokit/endpoint v6.0.1 (14a904d)
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using cdn.pika.dev to import the library into the browser, but that no longer works. Replacing it with cdn.skypack.dev will make it work again.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    More than one person can work on this issue, don't worry if it's already claimed.

  • πŸ“ Update the file \README.md (press the little pen Icon) and edit as shown below:

@@ -40,11 +40,11 @@ See the [official deprecation announcement](https://developer.github.com/changes
 Browsers
 </th><td width=100%>
 
-Load `@octokit/auth-basic` directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/auth-basic` directly from [cdn.skypack.dev](https://cdn.skypack.dev)
 
 ```html
 <script type="module">
-  import { createBasicAuth } from "https://cdn.pika.dev/@octokit/auth-basic";
+  import { createBasicAuth } from "https://cdn.skypack.dev/@octokit/auth-basic";
 </script>
 ```
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
    2. You can edit files directly in your browser
  • 🏁 Done Ask for a review :)

If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using @Co-authored-by, so yo can be sure your contribution will count.

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

An in-range update of fetch-mock is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The devDependency fetch-mock was updated from 9.3.0 to 9.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

fetch-mock is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • βœ… test (12): There are 1 failures, 0 warnings, and 0 notices.
  • βœ… test (10): There are 1 failures, 0 warnings, and 0 notices.
  • ❌ test (8): There are 1 failures, 0 warnings, and 0 notices.

Commits

The new version differs by 7 commits.

  • d22e983 linked to cheatsheet EVERYWHERE
  • 1d2557d Merge pull request #524 from wheresrhys/cheatsheet
  • 1dfc6c2 completed cheatsheet
  • 7efa6c5 cheatsheet formatting
  • 438c835 refined set up/teardown section of cheatsheet
  • 6a2d449 midway through writing cheatsheet content
  • 633cf3e improve documentation for when to use a named matcher

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of semantic-release is breaking the build 🚨

The devDependency semantic-release was updated from 17.0.2 to 17.0.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

semantic-release is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

Release Notes for v17.0.3

17.0.3 (2020-02-13)

Bug Fixes

  • pass a branch name to getGitAuthUrl (e7bede1)
Commits

The new version differs by 6 commits.

  • e7bede1 fix: pass a branch name to getGitAuthUrl
  • 8426b42 chore(package): update tempy to version 0.4.0
  • 804fc2a docs(Troubleshooting): release not found in prereleases branch (e.g. beta) after rebase on master) (#1444)
  • 389e331 chore(package): update got to version 10.5.2
  • a93c96f revert: fix: allow plugins to set environment variables to be used by other plugins
  • 68f7e92 fix: allow plugins to set environment variables to be used by other plugins

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.