Migrate to GTK+3 about xfce4-kbdleds-plugin HOT 11 CLOSED

Actually, it ended up being very trivial, and the code might even work with both 2 and 3 now, if you can still obtain a GTK+2 version of XFCE, so I’ll just make the PR.

from xfce4-kbdleds-plugin.

Are you sure this is enough?
Can you point me to some docs how to port GTK2 XFCE apps to GTK3?

from xfce4-kbdleds-plugin.

At least what can I see right now, we should bump GTK version in configure.ac.in

from xfce4-kbdleds-plugin.

All I know is that I installed XFCE 4.16, made the change in this PR, compiled, and ran ldd on the output, and it was linked to v3 and not to v2 and worked fine.

Anyway the only mention I saw of GTK in configure.ac.in is behind a dnl; in M4 that’s a comment isn’t it?

from xfce4-kbdleds-plugin.

You are right, dnl is a comment.
Anyway I need some docs )
Will not merge it yet

from xfce4-kbdleds-plugin.

My understanding is that v3 largely removes stuff that was already deprecated in recent v2 as well as sealing data types, but yes, probably worth finding some more detailed information to see if there’s anything else important.

from xfce4-kbdleds-plugin.

I investigated a bit, and then saw your commit messages )

• panel_slice_new0 is deprecated, but it is just a macros, that actually is replaced by g_slice_new0, see /usr/include/xfce4/libxfce4panel-2.0/libxfce4panel/xfce-panel-macros-46.h
• libxfce4panel.h includes xfce-panel-plugin.h

So your PR does not resolve the migration to GTK3.

Actually the build from master branch on my PC also is linked to libgtk-3.so.0. Maybe it is checked during 'configure' step which GTK version is available.
I will merge #7 because it removes the deprecated code.

from xfce4-kbdleds-plugin.

Help in migrating is appreciated

from xfce4-kbdleds-plugin.

The choice of whether to link to 2 or 3 is made by which library is present in the Requires: lines in the XFCE library .pc files, I think; in other words, the kbdleds plugin is built with either 2 or 3 based on whether XFCE itself is built with 2 or 3. When XFCE is built with 3, kbdleds is linked only to the GTK+3 .so file. What other migration is there that needs to be done? As far as I can tell, kbdleds is now GTK+3 compatible, isn’t it? Unless you mean also taking advantage of GTK+3-exclusive new features?

from xfce4-kbdleds-plugin.

Yes, I think it is compatible, if it links with libgtk3 and runs.
Maybe we should take some additional required steps that we don't know about.

from xfce4-kbdleds-plugin.

Closing due to inactivity

from xfce4-kbdleds-plugin.