Code Monkey home page Code Monkey logo

Comments (3)

maxbeatty avatar maxbeatty commented on June 10, 2024

@mdonnalley thanks for restoring the exit behavior! I noticed in your PR that you're using .catch(/EEXIT: 0/) in your tests. Is it possible to use .exit(0) instead for more consistency between the command and test (i.e., the command calls this.exit so my test would verify that with test.exit)?

maxbeatty/reproduce-oclif-test-exit-zero#7 is upgrading to the newest version of @oclif/test but failing because I am using .exit(0)

https://github.com/maxbeatty/reproduce-oclif-test-exit-zero/blob/0aca49ec6fb0d1180aef4ca391e8885bec2390ee/test/commands/hello/index.test.ts#L14

https://github.com/maxbeatty/reproduce-oclif-test-exit-zero/blob/0aca49ec6fb0d1180aef4ca391e8885bec2390ee/test/commands/hello/index.test.ts#L29

from core.

mdonnalley avatar mdonnalley commented on June 10, 2024

@maxbeatty Yes, it is possible. Those test are, for some unknown reason, using fancy-test directly instead of @oclif/test, which is what exposes the .exit option.

If I had rewritten it to use @ocilf/test it would have looked like this:

import {test} from '@oclif/test'

test
  .stdout()
  .do(() => {
    class Command extends Base {
      async run() {
        this.exit(0)
      }
    }

    return Command.run([])
    })
  .exit(0)
  .it('exits with 0')

from core.

maxbeatty avatar maxbeatty commented on June 10, 2024

apologies for the oversight on my end. this is all working as expected now. thank you!

maxbeatty/reproduce-oclif-test-exit-zero@532581b

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.