Comments (6)
As soon as we merge both PRs (#6 and #17, they are prio for me now ) i'll take a look at this
from ocean-subgraph.
yup, know the full deployments can't be that easily automated but we should still do a release with a changelog right before doing deployment. Then it's clear to users which version of code is deployed, and what changed. Like, renaming that key is a breaking change, but there's not even a commit message for it. Using PRs and npm run release
will do that
from ocean-subgraph.
As a matter of process: why is this a new issue, rather than a comment in the issue & PR for bringing in TVL?
Also note: it should be "TVL" not "TLV". I've commented in the PR, but I'm commenting here to help ensure that the mistake doesn't propagate:)
from ocean-subgraph.
because this is the place where it needs to be solved so it's an issue here. Issues should exist on the projects where they are actually solved, no backend dev gets active cause we add a comment on some market PR. This here is clearly backend, so it's also not up to market
devs to fix this somehow on the market (we simply can't), we are blocked by it. And the PR oceanprotocol/market#353 then states in its description that it is blocked by this. totalLockedValue
is how it is called in multiple places here in this repo in the code right now, it's the current reality.
So that would be another issue to create in this repo to make sure to change all those keys: https://github.com/oceanprotocol/ocean-subgraph/search?q=totalLockedValue. I would suggest creating a new issue for that instead of mixing it up with actually fixing the number.
By now, we have a responsibility problem in this repo which is almost abandoned because we consider certain enterprise work to be more important given that it takes more than 25 days to approve and merge the most basic PRs: #6
from ocean-subgraph.
so the fix for this was combined in #6 and not in separate PR, right? Did the rename of the key happen too?
And if it was fixed in there, is it also deployed? Are we using the actual documented release process? https://github.com/oceanprotocol/ocean-subgraph#%EF%B8%8F-releases
from ocean-subgraph.
It includes the rename but it was not deployed yet, will check and close the issue.
We are using it but the release is done on each env ( in aws), it can't be automated for now.
from ocean-subgraph.
Related Issues (20)
- Add timestamp to VeDelegation HOT 2
- Call veDelegation.save() on veDelegation BurnBoost event
- Publishing a dataset with USDC 6 decimal `publisherMarketFeeToken` have wrong `publishMarketFeeAmount` stored in subgraph HOT 9
- Improve tests HOT 5
- Add locked amount to veDelegation
- Improve test speed HOT 5
- Event index for `TokenCreated` & `NFTCreated` events are overriden in the handlers. This was discovered while trying to assert the event indexes in the tests. HOT 1
- add predictoor erc725 keys/values HOT 1
- Add tests for Predictoor
- Template id detection
- Use latest ocean.js HOT 1
- Reduce docker size
- Remove floatValue from predictoor handler
- Add truevalSubmitted into predictSlots
- Add contract address + filtering to PredictPrediction HOT 2
- Test 0xgraph graph HOT 1
- Migrate to latest graph-node
- Fix tests so you can run them multiple times
- [PDR][Lake] Update predictPredictions and predictSlots to feature lastEventTimestamp HOT 2
- [PDR][Lake] Enhance predictPayouts with Contract Address Array Filter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocean-subgraph.