Code Monkey home page Code Monkey logo

Comments (10)

pedrobaeza avatar pedrobaeza commented on August 19, 2024

I agree, but prefer to prepend partner_ to all modules

from partner-contact.

yajo avatar yajo commented on August 19, 2024

No problem. Do you mean for instance partner_contact_birthdate or partner_birthdate?

from partner-contact.

pedrobaeza avatar pedrobaeza commented on August 19, 2024

It seems to be more coherent to name them partner_contact_base, partner_contact_birthdate...

from partner-contact.

yajo avatar yajo commented on August 19, 2024

👍

from partner-contact.

yvaucher avatar yvaucher commented on August 19, 2024

IMO a contact being a partner I don't see the need of adding partner_ to all module technical names

And indeed a split of functionalities would be better.

from partner-contact.

yajo avatar yajo commented on August 19, 2024

Then please come to a consensus. For now I've started with @pedrobaeza suggestion. You can track progress if you want in https://github.com/grupoesoc/partner-contact/tree/deprecate-base_contact.

from partner-contact.

pedrobaeza avatar pedrobaeza commented on August 19, 2024

@yvaucher, partner prefix identify the "area" you are working with.

from partner-contact.

yvaucher avatar yvaucher commented on August 19, 2024

@pedrobaeza area should be given in __openerp__.py as category and partner_contact isn't an area in term of object. Plus renaming modules makes difficulties in migrations and we have no naming convention for module written in https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md

from partner-contact.

pedrobaeza avatar pedrobaeza commented on August 19, 2024

This was also debated in the past, because partner itself is not an area as you say, but it's a very important topic not to be included in the names. Odoo itself was debating to split base module to include all res.partner related stuff in a partner module. I was the one to think on not to put partner_ also until I speak with @hbrunn about it.

from partner-contact.

yvaucher avatar yvaucher commented on August 19, 2024

@pedrobaeza What about a talk with a PR on https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md ?

from partner-contact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.