Migration to version 10.0 about hr HOT 17 CLOSED

@pedrobaeza you can add #261 to hr_public_holidays too

from hr.

Please only 1 module per PR.

from hr.

hr_holidays_compute_days depends on hr_public_holidays. It means that people has to wait for merging hr_public_holidays before being able to review hr_holidays_compute_days. Also, hr_public_holidays has very few changes

from hr.

No, no need to wait. You make 2 PRs: one with hr_public_holidays, and another containing the previous commits + the module hr_holidays_compute_days, and mark as dependent. When the first one is merged, you only need to rebase. This is for making easier to merge PRs. If you include 2 modules, it will be more difficult to review, and less chances to be merged.

from hr.

I mean, that runbot and travis will not work, if hr_public_holidays is not installable.

from hr.

It will work. Second PR must include all the commits from the first one (the migration of hr_public_holidays), plus the commit/s for migrating the module hr_holidays_compute_days. This way, you can review the first PR, as well as reviewing code from specific commits in the second PR, or reviewing functionally the second one. If the first one gets merged, you rebase the second one and you have the second PR clean with only the commits for the second module.

Do you understand the process?

from hr.

Got it. Thank you for explanantion

Unfortunately, I already have commits, that make updates on both modules. I will separate it later if needed. I will definitely use this approach on next PRs

from hr.

OK, let's continue this time having both in one PR, but please take note for future times.

from hr.

Porting hr_employee_id: #272

from hr.

Porting hr_employee_phone_extension: #313

from hr.

Porting hr_emergency_contact: #314

from hr.

Porting hr_contract_reference: #316

from hr.

And a last one for now. Porting hr_employee_seniority: #319

from hr.

#370 migration to v10 of hr_holidays_validity_date

from hr.

@pedrobaeza As we get few (no) answer from the author of #300 and he is having trouble rebasing his work, can we superseed with #378 ?
I have cherry-picked his actual work and I'm going to test it before the end of the week.

from hr.

@leemannd Done

from hr.

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from hr.