Comments (17)
@pedrobaeza you can add #261 to hr_public_holidays too
from hr.
Please only 1 module per PR.
from hr.
hr_holidays_compute_days
depends on hr_public_holidays
. It means that people has to wait for merging hr_public_holidays
before being able to review hr_holidays_compute_days
. Also, hr_public_holidays
has very few changes
from hr.
No, no need to wait. You make 2 PRs: one with hr_public_holidays
, and another containing the previous commits + the module hr_holidays_compute_days
, and mark as dependent. When the first one is merged, you only need to rebase. This is for making easier to merge PRs. If you include 2 modules, it will be more difficult to review, and less chances to be merged.
from hr.
I mean, that runbot and travis will not work, if hr_public_holidays is not installable.
from hr.
It will work. Second PR must include all the commits from the first one (the migration of hr_public_holidays
), plus the commit/s for migrating the module hr_holidays_compute_days
. This way, you can review the first PR, as well as reviewing code from specific commits in the second PR, or reviewing functionally the second one. If the first one gets merged, you rebase the second one and you have the second PR clean with only the commits for the second module.
Do you understand the process?
from hr.
Got it. Thank you for explanantion
Unfortunately, I already have commits, that make updates on both modules. I will separate it later if needed. I will definitely use this approach on next PRs
from hr.
OK, let's continue this time having both in one PR, but please take note for future times.
from hr.
Porting hr_employee_id: #272
from hr.
Porting hr_employee_phone_extension: #313
from hr.
Porting hr_emergency_contact: #314
from hr.
Porting hr_contract_reference: #316
from hr.
And a last one for now. Porting hr_employee_seniority: #319
from hr.
#370 migration to v10 of hr_holidays_validity_date
from hr.
@pedrobaeza As we get few (no) answer from the author of #300 and he is having trouble rebasing his work, can we superseed with #378 ?
I have cherry-picked his actual work and I'm going to test it before the end of the week.
from hr.
@leemannd Done
from hr.
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.
from hr.
Related Issues (20)
- [14.0] [BUG] hr_period - Instal error , comparison with false
- How can I use inputs on salary rules? HOT 1
- Migration to version 16.0 HOT 24
- [14.0][hr_employee_calendar_planning] We cannot create employee from a user HOT 3
- [odoo 15] [hr_contract_employee_calendar_planning] Cant install this module HOT 1
- Attendance throws error "Invalid field 'birth_name' on model 'hr.employee.public'" HOT 4
- hr_org_chart_overview is not showing the title of the employees HOT 2
- conflicts with odoo core function for allocation accrual cron job HOT 1
- [15.0] "psycopg2.errors.InvalidColumnReference: there is no unique or exclusion constraint matching the ON CONFLICT specification" when I try to install hr_employee_calendar_planning HOT 2
- hr_holidays_notify_employee_manager : email template HOT 1
- AttributeError: 'hr.applicant' object attribute 'name' is read-only HOT 2
- [14.0] hr_holidays_settings: duplicated in OCA / hr-holidays repo HOT 2
- can upgrade to odoo 16 Petty Cash HOT 1
- Odoo HR planning HOT 1
- hr_employee_birthday_mail: ValueError: Invalid field 'allow_birthday_wishes' on model 'hr.employee.public' HOT 1
- Using Repo v14.0 for v16.0 HOT 1
- hr_org_chart_overview Multicompany doesn't work HOT 1
- [RFC] module to restrict HR officer to their own subordinates? HOT 1
- Migration to version 17.0 HOT 14
- Data model on hr employee relative is redefining field instead of using oca partner contact modules HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hr.