Support for WebSockets about oauth2-proxy HOT 9 CLOSED

I am not sure wether this is fixed or not. i was trying to proxy octant using latest 6.1.1 version oauth_proxy, and i ended up with the same error:

create websocket client {"err": "websocket: the client is not using the websocket protocol: 'upgrade' token not found in 'Connection' header"}

Is it really solved, or am i missing some config

    cookie_secure = false
    provider = "oidc"
    redirect_url = "https://localhost/oauth2/callback"
    oidc_issuer_url = "https://auth.example.com/"
    email_domains = [ "example.com" ]
    upstreams = [ "http://localhost:3309/" ]
    skip_provider_button =  true
    pass_access_token = true
    proxy_websockets = true

from oauth2-proxy.

I noticed that go-1.12 will add WebSocket support to httputil.ReverseProxy (which oauth2_proxy uses)
https://tip.golang.org/doc/go1.12#net/http/httputil

from oauth2-proxy.

Thanks for the response @ploxiln. I have built the oauth2_proxy image using golang:1.12-rc-stretch as base image but the result is the same. Is there something else that I can try?

from oauth2-proxy.

@andresmgot Do you have time to try merging the changes from bitly/oauth2_proxy#554 into a branch and testing this with your setup?

from oauth2-proxy.

Hi, I tried using bitly/oauth2_proxy#554 and got oauth2-proxy websockets working with a basic nodejs websocket connection successfully. Works great. But when I try with Jupyterlab (Tornado Server) I get "Error during WebSocket handshake: Unexpected response code: 500". Any ideas why tornado server in jupyter would have issue?

from oauth2-proxy.

this feature was completed (a bit differently I think) and merged in #92

from oauth2-proxy.

@cbbba18 I got similar issue. I made some investigation and made a fix at #112.

from oauth2-proxy.

Is this issue now resolved? #92 and #112 should have fixed this and have been released?

from oauth2-proxy.

Thank you all. Yes, this should be fixed now. I will reopen the issue if I find any other problem with that.

from oauth2-proxy.