Code Monkey home page Code Monkey logo

Comments (7)

benley avatar benley commented on June 5, 2024 2

It appears that this is still not fixed in 3.2.0 or master. Has someone opened a new PR to replace bitly/oauth2_proxy#395 and fix this, or is there another fix pending, or something else?

from oauth2-proxy.

JoelSpeed avatar JoelSpeed commented on June 5, 2024

I believe this may have been fixed in #24 which was merged earlier today, would you be able to test the current master build with the flag set to true?

from oauth2-proxy.

christidis avatar christidis commented on June 5, 2024

Hm, I have just given quay.io/pusher/oauth2_proxy latest and master tags a try but noticed the same thing. URL is not preserved when -skip-provider-button=true is set.

from oauth2-proxy.

JoelSpeed avatar JoelSpeed commented on June 5, 2024

In which case this will need further investigation

from oauth2-proxy.

rmoriz avatar rmoriz commented on June 5, 2024

there is a PR at bitly/oauth2_proxy#395

from oauth2-proxy.

framillien avatar framillien commented on June 5, 2024

Hello, migrating from 3.0 to 3.1 fix this issue for me. I have removed option "-skip-provider-button", since original URL was not respected.

But this is now fixed in last version. Looking at code, it's the expected fix : take redirect from URL instead of unpopulated "rd" parameter (since "rd" is populated by skipped page)

Thanks,

@christidis : On quay.io I see that 3.1.0 was updated 5 days ago. Maybe the latest was not the 3.1.0 when you have done your test ?

from oauth2-proxy.

github-actions avatar github-actions commented on June 5, 2024

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

from oauth2-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.