How to catch this exception about oatpp HOT 4 CLOSED

Thanks for the update. Let me mark this as closed now.

from oatpp.

Hello @alex-lt-kong ,

This throw war introduced in the latest commit - oatpp/oatpp-openssl@55cf90b#diff-154b6b83b07306666e4b4cd5ef5e173c72e54cad2432d8ee68ae39a0a1778a9cR71

Before we were just ignoring handshake failure.
Actually, I don't really think it is an error - not a fatal one for sure.

However, it's strange that your program crashes...
Is it a client program that you are running? Like you are trying to connect to remote server, handshake fails, and program crashes?

The easiest way would be to wrap this call with try-catch block.
However, I'm thinking if we need to throw and log this event at all.

from oatpp.

Hi @lganzzzo ,

My program is an http service, not client, with SSL enabled. Regarding try-catch, usually my code in controller is executed in a sort-of callback manner, I actually have no idea where to add try-catch--and thus the subject of this issue.

ICYW, this is the entry point of Oatpp in my program, can you tell me where I should put a try-catch to catch the above-mentioned exception?

Let me also add my two cents to the throw war: my personal preference is that, as an HTTP framework, exceptions should only be propagated up to user's code in a few extreme cases. For example, port being occupied and memory allocation failure, where all hope to keep the service running is lost; otherwise users may prefer having the service running and let these exceptions be logged/returned to client (i.e., status code 500).

from oatpp.

Hello @alex-lt-kong ,

This issue was fixes. Please checkout the latest oatpp-openssl master.

Let me also add my two cents to the throw war: my personal preference is that, as an HTTP framework, exceptions should only be propagated up to user's code in a few extreme cases. For example, port being occupied and memory allocation failure, where all hope to keep the service running is lost; otherwise users may prefer having the service running and let these exceptions be logged/returned to client (i.e., status code 500).

I agree 100%.
This bug was introduced by adding unnecessary throw in oatpp-openssl connection handshake.
And it appears that connection stream context initialization (handshake in case of oatpp-openssl connection) isn't protected with try-catch here

As further steps we'll have to add a better top-level error handling inside oatpp itself.

from oatpp.