warn instead of error for SHOULD about cti-stix-validator HOT 4 CLOSED

Thanks, @jmgnc.

Right now we don't distinguish "errors" from "warnings". Specific checks can be turned on and off using --enable or --disable. Additionally, all of the SHOULD checks can be turned off with --lax.

Do you think the current implementation is sufficient, or do we need to distinguish errors from warnings (besides being able to selectively turn them on and off)?

from cti-stix-validator.

I think supporting warnings would be a good thing. It lets those warnings
be annoying as opposed to turning them off prevents you from seeing when
new warning happen. It's also not clear from the table which of the errors
are SHOULDs versus MUSTs.

On Tue, Nov 22, 2016 at 7:19 AM, Greg Back [email protected] wrote:

Thanks, @jmgnc https://github.com/jmgnc.

Right now we don't distinguish "errors" from "warnings". Specific checks
can be turned on and off using --enable or --disable. Additionally, all
of the SHOULD checks can be turned off with --lax.

Do you think the current implementation is sufficient, or do we need to
distinguish errors from warnings (besides being able to selectively turn
them on and off)?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCthQN7DfgIO5wyDq0U_mnC-FK8VPgtks5rAwftgaJpZM4K418h
.

from cti-stix-validator.

It'd be great to see this same warning behavior applied to open vocabularies. According to the spec, it's acceptable to use custom values in an open-vocab field (which consumers are free to ignore).

The value of the property SHOULD be chosen from the suggested vocabulary but MAY be any other string value.

The validator treats this as an error right now.

Example:

malware--031e8443-3a44-5068-b897-7a242b69b0b6: {216} labels contains a value not in the malware-label-ov vocabulary.

Edit: Just saw the other issue that mentions this. To me, they're effectively the same issue. Best practices are great, but they should not fail validation.

from cti-stix-validator.

Sounds good! We'll take a look.

from cti-stix-validator.