Make list comprehensions more idiomatic about cti-python-stix2 HOT 3 CLOSED

Note that some people think a listcomp is more idiomatic than filter, so it's debatable whether the latter examples should be changed. The former ones should, however.

from cti-python-stix2.

If the iterable is a sequence which supports slicing, the first can more compactly be done as:

list_copy = original_list[:]

(of course,be sure a shallow copy is what you are after.) For the second, I much prefer the comprehension. Also for the latter (and in general), I prefer a generator expression, if you can get away with it. I think you should try not to make copies or intermediate lists (or other data structures) unnecessarily.

(P.s. I haven't actually searched the code to understand what contexts these constructs occur in.)

from cti-python-stix2.

I've always used list(X) to consume a generator rather than X[:] (it also helps ensure the iterable is a list, if that's desired, rather than keeping the same iterable type). I'm not sure which more common/accepted/idiomatic, though.

I also agree that, where possible, generator expressions are preferable to list comprehensions, unless you need the list.

from cti-python-stix2.