Code Monkey home page Code Monkey logo

Comments (2)

BradLugo avatar BradLugo commented on September 27, 2024

This seems to be the cause (specifically the int(partition_number) toward the bottom):

convert2rhel/convert2rhel/grub.py

Lines 156 to 178 in 985cf34

def get_device_number(device):
"""Get the partition number of a particular device.
This method will use `blkid` to determinate what is the partition number
related to a particular device.
:param device: The device to be analyzed.
:type device: str
:return: The device partition number.
:rtype: int
"""
output, ecode = utils.run_subprocess(
["/usr/sbin/blkid", "-p", "-s", "PART_ENTRY_NUMBER", device], print_output=False
)
if ecode:
logger.debug("blkid output:\n-----\n%s\n-----" % output)
raise BootloaderError("Unable to get information about the '%s' device" % device)
# We are spliting the partition entry number, and we are just taking that
# output as our desired partition number
if not output:
raise BootloaderError("The '%s' device has no PART_ENTRY_NUMBER" % device)
partition_number = output.split("PART_ENTRY_NUMBER=")[-1].replace('"', "")
return int(partition_number)

I'm not too familiar with these lower-level details (trying to get better 😄), but I'm also having a difficult time figuring out what we might use the partition entry number for since the caller doesn't give any hints (at least, not with my current understanding):

convert2rhel/convert2rhel/actions/system_checks/efi.py

Lines 70 to 83 in 985cf34

# Get information about the bootloader. Currently, the data is not used, but it's
# good to check that we can obtain all the required data before the PONR.
try:
efiboot_info = grub.EFIBootInfo()
grub.get_device_number(grub.get_efi_partition())
except grub.BootloaderError as e:
self.set_result(
level="ERROR",
id="BOOTLOADER_ERROR",
title="Bootloader error detected",
description="An unknown bootloader error occurred, please look at the diagnosis for more information.",
diagnosis=str(e),
)
return

from convert2rhel.

bocekm avatar bocekm commented on September 27, 2024

I'd say this is not resolved. With #1169 convert2rhel does not traceback but still provides just a more graceful error message. The problem seems to be that we can't handle RAID+UEFI. A similar issue has been reported under #1247. Let's continue tracking the problem there.

from convert2rhel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.