Comments (3)
What is the use case of subclassing router, and why does access to private methods make it difficult?
from oak.
@kitsonk So Router
has lots of awesome functionality, which I'm sure wasn't trivial to implement. Subclassing the router could have all sorts of use cases, for example in order to programmatically configure the router given a formal API specification. As far as I've been able to tell, it's impossible to call #register
or #useVerbs
from the outside, so to speak.
Is there any particular reason why these methods are private in the first place?
from oak.
Because they don't make part of the public API of the router.
The oak router is not meant to be derivable. If it is missing features, those would stand on its own merits for consideration. The current abstraction that I want to maintain as part of the project, and would consider exposing non-public methods as not a desire of the project. Therefore, respectfully declined.
from oak.
Related Issues (20)
- Add Security Policy and enable Private Security Reporting HOT 1
- Uncaught TypeError if ServerSentEvent is created without optional EventInit HOT 3
- "connection closed before message completed" when closing SSE response HOT 1
- Globally catch body parsing errors HOT 6
- Using await inside onmessage callback voids subsequent ws.send calls... HOT 3
- No graceful shutdown behavior
- Multipart/form-data has zero files when no Content-Type header is present HOT 1
- Oak listens on wrong host/port and doesn't seem to accept requests HOT 1
- How to pass data to the frontend (Missing docs?)
- how do use extension in parameterized route?
- static file larger than 1MB cause memory leak HOT 2
- Unable to set request body in tests HOT 5
- Memory leak while reading body as "stream"
- Http - connection closed before message completed HOT 1
- Using Range headers for more than just bytes
- Sending large files from Oak server to the client
- Support Type-Safety Headers
- Could we make it return all the connect info? HOT 1
- How can i mock a `ctx.request.body` with oak HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oak.