Code Monkey home page Code Monkey logo

Comments (5)

khalwat avatar khalwat commented on August 15, 2024

So I think the reason this happens is that under the hood, Craft probably does something like deleting the assets from one Asset Volume, and moving them to the other. Given that asset transforms sit in a folder in the same sub-folder as the asset, all of the transforms and their parents folders would need to be moved when an Asset is moved.

The real "bug" here I think would be for P&T, where we might want it to (maybe?) move any generated transforms when an Asset is moved, rather than just expecting them to be recreated (which is what it sounds like is happening).

This is without looking into it in depth, just what I think is likely happening.

from craft-imageoptimize.

riasvdv avatar riasvdv commented on August 15, 2024

Yeah I haven't looked into what was really happening either, though I don't think P&T are recreating the assets as the IDs are kept exactly the same, only a folderPath column gets changed in the database. But maybe the events that are being triggered are the same as deleting/adding

from craft-imageoptimize.

khalwat avatar khalwat commented on August 15, 2024

What's happening is that when you move a bunch of images, the transforms all get nuked, and then ImageOptimize goes to recreate them... but it does it immediately, so it can take some time to do if there are a bunch of them.

I'll see if there is a way to shuffle it off into a queue in this instance.

from craft-imageoptimize.

khalwat avatar khalwat commented on August 15, 2024

This should be addressed in 1.4.23:

https://github.com/nystudio107/craft-imageoptimize/releases/tag/1.4.23

from craft-imageoptimize.

riasvdv avatar riasvdv commented on August 15, 2024

Great, that fixed it!

from craft-imageoptimize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.