Code Monkey home page Code Monkey logo

Comments (11)

CarterLi avatar CarterLi commented on July 24, 2024

Seems that this plugin doesn't like ESLyric. The music plays fine if I disable "foo_uie_eslyric.dll"

But... What's happenning with the progress bar?

from foo_thbgm.

nyfair avatar nyfair commented on July 24, 2024

foo_thbgm will hook the progress bar because all touhou BGM's can loop
It's a main feature of foo_thbgm

from foo_thbgm.

CarterLi avatar CarterLi commented on July 24, 2024

Can I disable the inf-looping feature?
Any idea with the compatibility of ESLyric?

from foo_thbgm.

nyfair avatar nyfair commented on July 24, 2024

sure, you can set loop_count to 1 in the playback menu

from foo_thbgm.

nyfair avatar nyfair commented on July 24, 2024

Aha, finally i found the issue about ESLyric.

That crazy plugin will try to iterate all other plugin's get_info interface when playing musics. This is very hackish and may conflict with many other plugins.
I also checked with the source code of several other lyrics plugins. They never to this and will cache music's information when loading the music files.

You can also see in the stack dump.
foo_uie_eslyric can't parse the return data from foo_thbgm because it can't recognize ZUN's particular WAVE head. Thus cause the crash.

Anyway, if you really need to use ESLyric, I can also do a test build for you to forbid ESLyric visiting foo_thbgm's interface.

from foo_thbgm.

CarterLi avatar CarterLi commented on July 24, 2024

Anyway, if you really need to use ESLyric, I can also do a test build for you to forbid ESLyric visiting foo_thbgm's interface.

Good! But instead of "forbiding ESLyric visiting foo_thbgm's interface", could you return some data which is not THAT special, to make ESLyric ignore it safely. It's always not a good idea to hack code for some specified things since other plugins may have the same issue

from foo_thbgm.

nyfair avatar nyfair commented on July 24, 2024

Yes, I'll do these work this weekend, only because the modification has no downsides.
I still don't know why a lyrics plugin need to call other plugin's interface directly.

from foo_thbgm.

CarterLi avatar CarterLi commented on July 24, 2024

dump file uploaded:
http://pan.baidu.com/s/1mgqYACS
PWD: 5dd9

from foo_thbgm.

CarterLi avatar CarterLi commented on July 24, 2024

Detail information updated on the thread of Eslyric in Baidu Tieba
http://tieba.baidu.com/p/2370754361?pid=68658226844&cid=68687715638#68687715638

from foo_thbgm.

nyfair avatar nyfair commented on July 24, 2024

now Eslyric can read music data properly and will no longer conflict with each other, plz check the latest build and confirm

from foo_thbgm.

CarterLi avatar CarterLi commented on July 24, 2024

Confirmed, thanks

from foo_thbgm.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.