PR test coverage requirement about nw-builder HOT 7 OPEN

that is weird. it was failing on my local Mac AND on circle build. When I get a chance I'll review those tests to check if they're testing the right thing

from nw-builder.

ah - the decompress.test.js doesnt actually test if symlinks exist after extracting. it just runs runs a decompress and then continues. the macOS one should ALSO check that symlinks exist once decompress has finished

from nw-builder.

I think this is more relevant https://github.com/Bachmann1234/diff_cover

from nw-builder.

What's weird is that in both #1035 and #1040, the symlinks test passed in GitHub CI but failed on your local machine (or was it CircleCI?).

from nw-builder.

Any new PR's should have minimum test coverage requirements of 80% - but only for the changes.

https://coveralls.io/ ?

from nw-builder.