multiple event notifications - doesn't seem to respect position toggle when using fancy embeds about valheim-discordconnector HOT 8 CLOSED

I think I need to add return statements in EventWatcher.cs to stop it once it reaches an outcome

from valheim-discordconnector.

You may want to regenerate your Webhook since it was inside the config you posted.

I believe I've fixed the issue and will include it in the next release. Attached is a build including the fix if you want to try it out now (only change being the Event duplicate message fix)

DiscordConnector.zip

from valheim-discordconnector.

Yeah its definitely sending two messages. One with and one without coordinates. Probably an issue in the logic determining how to send it.

from valheim-discordconnector.

Thanks for your time and attention on these issues. really working well for our server. especially since I'll be going public in a week or two and removing the password.

from valheim-discordconnector.

This isn't just when fancy messages are enabled. All of our event POS toggles are set to false, but the POS is still being sent with one of the messages. I am deleting them as I see them so that base locations aren't revealed as much...

from valheim-discordconnector.

Do you know which event message is sending it? -- Meaning Start/Pause/Resume/Stop

from valheim-discordconnector.

Actually I think I see the logic issue I didn't.

All the event message sections (in dev, and the .zip above) have the following:

                if (!Plugin.StaticConfig.EventStopPosEnabled)
                {
                    DiscordApi.SendMessage(message);
                    return;
                }

Which if POS is disabled sends the message and stops executing code for that method. That exists for all start/stop/pause/resume.

I will release this patch now

from valheim-discordconnector.

Do you know which event message is sending it? -- Meaning Start/Pause/Resume/Stop

I might have gotten this to you a little late, but I don't at the moment as I deleted them. It looked very similar to the first person in this thread, so I am assuming it is the second event start message. I will test out 1.4.4 later today, but I'll assume it's fixed there =] Thanks for the update

from valheim-discordconnector.