Code Monkey home page Code Monkey logo

Comments (5)

arash-vahdat avatar arash-vahdat commented on August 18, 2024

Thanks for catching this. Technically, we shouldn't have two ELUs after each other. Unfortunately, fixing this requires retraining all our checkpoints again with the updated network. We will try to fix this in our future major revision.

from nvae.

bfs18 avatar bfs18 commented on August 18, 2024

Thanks a lot for your reply.

from nvae.

bfs18 avatar bfs18 commented on August 18, 2024

Hi @arash-vahdat
the decoder sampler cell is nn.ELU + Conv2D

NVAE/model.py

Line 274 in 38eb997

nn.ELU(),

but the encoder sampler is only a Conv2D layer

NVAE/model.py

Line 263 in 38eb997

cell = Conv2D(num_c, 2 * self.num_latent_per_group, kernel_size=3, padding=1, bias=True)

The outputs of encoder_tower and decoder_tower are not squashed by an activation function. Only encoder0 has an output activation function.

NVAE/model.py

Line 253 in 38eb997

nn.ELU())

I am curious about the difference between the encoder and decoder samplers. Is this a deliberated design?

from nvae.

arash-vahdat avatar arash-vahdat commented on August 18, 2024

encoder0 is an outlier (it is a kind of a legacy branch from some old idea that didn't work out. We will remove it in the future). The fact that the encoder sampler doesn't apply any activation function is by design. I think I did experiments at some point with adding an activation and normalization and I didn't see any improvements.

from nvae.

bfs18 avatar bfs18 commented on August 18, 2024

I see. Thanks a lot.

from nvae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.