Code Monkey home page Code Monkey logo

Comments (4)

jaredcasper avatar jaredcasper commented on July 21, 2024 1

It's on the list but pretty low priority since we seldom run into it. If you can figure out why the lock mechanism in torch.utils.cpp_extension.load doesn't always work as I think it should I'm all ears. :) Might be we are expecting more from it than it is meant to handle, might be we are using it wrong, might be a bug in torch, etc.

from megatron-lm.

jaredcasper avatar jaredcasper commented on July 21, 2024

We've had reports of this happening internally as well. The problem with only compiling on the master rank is we need to support the use case that the code lives locally on several nodes (i.e. a multinode environment and the code isn't on a shared disk). So the kernels need to be compiled on several ranks.

torch.utils.cpp_extension.load is supposed to lock the directory so that only one rank runs the build at a time (and only the first run actually does anything, subsequent runs just see that it is already built and returns). Apparently that lock isn't properly deleted/released in some instances.

from megatron-lm.

wade3han avatar wade3han commented on July 21, 2024

Thanks for your response! I'm glad that your group already had reports of this happening.
Is your group internally planning to resolve this issue?

from megatron-lm.

wade3han avatar wade3han commented on July 21, 2024

I will close this issue, and if there is an additional issue then I will re-open it. Thank you :)

from megatron-lm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.