Support i18n module about sitemap HOT 5 CLOSED

Hey, thanks for the issue!

I've added the inferStaticPagesAsRoutes to escape from using generateUrls, available in 1.0.5.

export default defineNuxtConfig({
  sitemap: {
    inferStaticPagesAsRoutes: false,
  }
})

I'll be looking to support i18n properly soon, if you have any other ideas on what the integration should look like, please let me know :)

from sitemap.

@harlan-zw
It works like a charm, thanks 👌

PS In the README.md, it is said that the include property default value is undefined.
While in reality, its default value (src/module.ts line 69) is include: ['/**'].
You should update the README properties values to reflect reality.

from sitemap.

@harlan-zw It works like a charm, thanks ok_hand

PS In the README.md, it is said that the include property default value is undefined. While in reality, its default value (src/module.ts line 69) is include: ['/**']. You should update the README properties values to reflect reality.

Thanks, have updated the doc. Did you run into an issue with it being ['/**'*']?

from sitemap.

Nope, no issues.

I find it weird to have include and exclude rules applied to both urls and prerendedRoutes since the challenges for those two arrays are different.

Plus, you run urlFilter two times.
The first time inside generateUrls, thus on the soon-to-be populated urls array.
The second time directly on the merged array [...urls, ...prerendedRoutes].
Consequently, you run the filter function twice on a section of the final URLs.

from sitemap.

Nope, no issues.

I find it weird to have include and exclude rules applied to both urls and prerendedRoutes since the challenges for those two arrays are different.

Plus, you run urlFilter two times. The first time inside generateUrls, thus on the soon-to-be populated urls array. The second time directly on the merged array [...urls, ...prerendedRoutes]. Consequently, you run the filter function twice on a section of the final URLs.

Agreed, the code isn't as good as it could be, optimised for getting it finished. Will refactor it at some point when I add a new feature. Always happy to receive PRs too :P

from sitemap.