Code Monkey home page Code Monkey logo

Comments (5)

ChrisMaddock avatar ChrisMaddock commented on August 20, 2024

I've just added the new page - @CharliePoole, would you mind reviewing what I've done?

The new page is: https://github.com/nunit/docs/wiki/Template-Based-Test-Naming

It is linked from TestCaseAttribute and TestCaseData. I just took the second half from the spec page - that was the bit that seemed relevant from a documentation point of view.

Will close this issue after review.

from docs.

CharliePoole avatar CharliePoole commented on August 20, 2024

Nice! Some specific comments here:

  • Although it's covered further down, I think you need something in the first lines that indicates that there is a default naming convention and that use of this facility is optional.

  • The description of how we generate the fullname is incorrect. There is no template for the fullname. Rather we simply append the test case name to the class name, separated by a '.' character. If we allowed the fullname and name to vary independently, a number of things would break internally. 😢

Otherwise, looks great to me.

from docs.

ChrisMaddock avatar ChrisMaddock commented on August 20, 2024

Thanks @CharliePoole.

I've edited the first paragraph.

  • Can you clarify where the error is with fullname's? I'm assuming you mean that fullname for method isn't always "Equivalent to {n}.{c}.{m} or {C}.{m}"?
  • Is the "Standard Name Formats" still accurate, re: truncating the arguments after 40 characters? I have vague memories that we considered moving the truncating functionality to the runners - but I can't remember if anything ever came of that, or find the relevant issues.

Update: Never mind on the last point - I found the PR I was thinking of, and updated! (It was nunit/nunit#1556)

from docs.

CharliePoole avatar CharliePoole commented on August 20, 2024

Generation fo the fullname is not currently template-based, as is hinted by your example of a template. By default, it looks as if it is generated by the template you list but it really isn't. Where you see the difference is if you change the test name, then the fullname changes as well. There is no way the user can modify how the fullname is created.

from docs.

ChrisMaddock avatar ChrisMaddock commented on August 20, 2024

Thanks Charlie - I made the change. Sorry it took a while, this was the last thing I did before going on holiday!

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.