Comments (3)
This also happens with data-animate
.
from juxtapose.
You're right that these are the same issue. I added the handling for booleans because the string 'false' doesn't evaluate to the boolean value false. There's also the problem of how to handle null values, which is what happens here. scanPage puts something in for each of the official options, whether or not an attribute was specified in the markup.
I think the correct behavior is probably to resolve all of this in scan page, and document that the options object passed to juxtapose.JXSlider must correctly use javascript booleans for option values. If someone passes the string "false", that's their mistake, not something we have to protect them from.
So then, scanPage, knowing that its reading HTML, can deal with the absence or presence of attributes and with converting their values to booleans. It could also not pass a null value if the attribute isn't present in the markup.
What do you think?
from juxtapose.
I think that seems fine and makes sense.
from juxtapose.
Related Issues (20)
- facebook og:issues HOT 1
- can I compare gif image? HOT 1
- Lots of white space on mobile HOT 3
- Unwanted margins appear between JUXTAPOSE and next image HOT 1
- Juxaposejs
- Allow updateSlider to go all the way left or right
- When resize the comparison window, the image in the right side always get more blurry than the left HOT 1
- Use data credit/label value outside img tag HOT 1
- Hotlinking Imgur images does not work HOT 2
- Multiple Sliders HOT 1
- Juxtapose in Jupyter notebook cell causes TypeError in `setWrapperDimensions` HOT 1
- Before_after slider defaults to left of page in landscape.
- How to prevent scrolling on axis Y? HOT 1
- Juxtapose embed not displaying on Safari on iOS HOT 3
- local file upload HOT 1
- Embed with [https://juxtapose.knightlab.com/] not working anymore ? HOT 1
- Could not communicate with Dropbox HOT 1
- Invisible Image HOT 6
- Behance Bug
- can't use in web component
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from juxtapose.