Labels Don't Show Up about juxtapose HOT 3 CLOSED

This also happens with data-animate.

from juxtapose.

You're right that these are the same issue. I added the handling for booleans because the string 'false' doesn't evaluate to the boolean value false. There's also the problem of how to handle null values, which is what happens here. scanPage puts something in for each of the official options, whether or not an attribute was specified in the markup.

I think the correct behavior is probably to resolve all of this in scan page, and document that the options object passed to juxtapose.JXSlider must correctly use javascript booleans for option values. If someone passes the string "false", that's their mistake, not something we have to protect them from.

So then, scanPage, knowing that its reading HTML, can deal with the absence or presence of attributes and with converting their values to booleans. It could also not pass a null value if the attribute isn't present in the markup.

What do you think?

from juxtapose.

I think that seems fine and makes sense.

from juxtapose.