Code Monkey home page Code Monkey logo

Comments (5)

nukeop avatar nukeop commented on June 11, 2024

This can be implemented with these events: https://www.electronjs.org/docs/latest/api/browser-window#event-app-command-windows-linux

from nuclear.

L30R avatar L30R commented on June 11, 2024

Hello i'm a learning dev and this implementation seems interesting, for adding purpose, i would like to know in what file this implementation would need to be in ?

from nuclear.

nukeop avatar nukeop commented on June 11, 2024

Somewhere in the main package. For example, we handle many different events here: https://github.com/nukeop/nuclear/blob/master/packages/main/src/main.ts

However, since it requires handling different events per platform, it may also be a part of platform-specific services, which can be found here as @linux, @mac and @windows: https://github.com/nukeop/nuclear/tree/master/packages/main/src/services

from nuclear.

L30R avatar L30R commented on June 11, 2024

I did work on this but was a little too slow, so i tried to adapt the part from the "if" into "switch" from the PR as nuki-chan said. I don't know if i did thing correctly or if this was necessary, i do apologies if this is not. The PR is #1567.

from nuclear.

nukeop avatar nukeop commented on June 11, 2024

Hm, I'd like to merge both of your PRs to acknowledge your contributions. And in fact both are necessary, because yours doesn't include @hollow-owl 's code. If I merge his first, then your PR will cause a merge conflict. You could try pulling changes from his fork first, then both your commits will be included, and merging your PR will effectively merge both PRs.

from nuclear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.