Code Monkey home page Code Monkey logo

Comments (3)

nukeop avatar nukeop commented on June 11, 2024

This should instead remove the affected track from the queue, and I'm pretty sure that in does, when the request to the streaming service results in a 404

from nuclear.

sferra avatar sferra commented on June 11, 2024

Yet the track isn't removed. It can be easily reproduced with the steps above.
There is no 404, since the stream itself is undefined.

IMO the unavailable stream should be removed and if it's the last one then the track should be probably removed, at least as a first fix. It would be nicer IMO to mark the track as unavailable and skip to the next one, instead of letting it magically disappear.

I have a local fix for removing the unavailable stream, if you are willing to reproduce & review.

Edit:
Maybe I should have clarified better: the information for the track is available from the stream provider (we know its name, length, etc.) but there's just no streaming source available (StreamData.stream). It's an edge case.

from nuclear.

nukeop avatar nukeop commented on June 11, 2024

Fixed by #1562

from nuclear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.