Comments (3)
This should instead remove the affected track from the queue, and I'm pretty sure that in does, when the request to the streaming service results in a 404
from nuclear.
Yet the track isn't removed. It can be easily reproduced with the steps above.
There is no 404, since the stream itself is undefined
.
IMO the unavailable stream should be removed and if it's the last one then the track should be probably removed, at least as a first fix. It would be nicer IMO to mark the track as unavailable and skip to the next one, instead of letting it magically disappear.
I have a local fix for removing the unavailable stream, if you are willing to reproduce & review.
Edit:
Maybe I should have clarified better: the information for the track is available from the stream provider (we know its name, length, etc.) but there's just no streaming source available (StreamData.stream
). It's an edge case.
from nuclear.
Fixed by #1562
from nuclear.
Related Issues (20)
- Hijacked testimonials HOT 4
- Téléghargement HOT 2
- Player options popup menu has a broken layout HOT 8
- Empty Playlists HOT 1
- Play counts not aligned HOT 1
- Add all tracks in the queue to an existing playlist HOT 7
- Playlist dialog title not translated (english only) HOT 2
- Cancelling importing a json file in playlist screen crashes the app
- Untranslated string HOT 1
- More untranslated strings HOT 1
- Miniplayer bugged controls HOT 3
- Global next/previous track shortcuts HOT 4
- Inaccurate tracks HOT 1
- Lyrics scroll back to the top on new song HOT 4
- Playlist net request issues HOT 1
- loading time is slow HOT 1
- App can't run after built ,the reason is scanner used the build machine's path HOT 4
- incorrect music downloads HOT 2
- I need the Nuclear Music Android app Please. HOT 2
- Sync playlist with youtube HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuclear.