Comments (1)
- Hm, I'm not entirely sure on the usefulness of the scheme argument, considering it already selects the scheme based on the url's scheme already. The only benefit would be the ability to set the default in case no scheme was provided with the url.
- nice catch on the typo.
- autocast not returning a real Datetime object is mostly intentional. Not saying it's not a good idea, but I'm trying to keep things somewhat lightweight, and if I changed it now it'd cause a pretty major incompatibility with people's existing code. I'm trying to avoid such things.
It's also perfectly fine to overload the _autocast function with your own if it suits your needs. I should probably add some function to provide an "official" way of doing that though.
On a side note, I noticed your code removed the integer check. There is a reason for that value.strip("-").isdigit() check; A raised exception is quite a few times more expensive than the cost of that check, and without it, it throws two exceptions per _autocast() if the value is not a number, instead of just one for the float() call.
- version tag, uhm, it's pretty much going to be stuck at 2 for the rest of its useful life. With the upcoming CREST API I don't think this will be very relevant anymore. I will add the attribute as it doesn't hurt, but...
- Your custom Exception, you're using a Warning for that and not an Error? I'm not about to let the parser continue on something that is for sure not what it's designed to parse. If you have a good reason to let it continue, I'd like to hear it.
Edit: and thanks for the invitation, but I have enough stuff on my TODO list as it is :)
from eveapi.
Related Issues (16)
- eveapi starbase detail not pulling correctly. part 2 HOT 5
- Get errors trying to run apitest.py HOT 6
- HTTP error codes HOT 3
- Migrate to Python 3.X HOT 1
- Messed columns in api.eve.CharacterAffiliation() HOT 3
- a bug from Serenity server API HOT 1
- Update pypi package to 1.3.2 (is 1.2.6 now) HOT 7
- Python 3 support on pypi HOT 1
- Requests returning errors are not cached HOT 1
- Empty attributes should be set to None HOT 2
- Certain keys should probably never be converted to int/float/date HOT 1
- Rowset column have a name, row - doesn't always have an attribute with this name HOT 1
- Recent fix for row data missing attributes that were defined in the rowset HOT 6
- TypeError when running apitest.py HOT 1
- eveapi starbase detail not pulling correctly. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eveapi.