Code Monkey home page Code Monkey logo

Comments (10)

jdfreder avatar jdfreder commented on May 17, 2024

ah, yes

from nteract.

captainsafia avatar captainsafia commented on May 17, 2024

Safia, do this!

from nteract.

betatim avatar betatim commented on May 17, 2024

Is this the issue about kernels being alive after quitting the app?

from nteract.

rgbkrk avatar rgbkrk commented on May 17, 2024

Yeah our cleanup isn't fully happening right now, leaving the connection files around.

from nteract.

betatim avatar betatim commented on May 17, 2024

The process seems to keep running as well. Check pgrep -f "python3 -m ipy" after starting and quitting nteract a few times.

from nteract.

betatim avatar betatim commented on May 17, 2024

Pressing Cmd+q is wired directly to app.quit() without creating a KILL_KERNEL action or calling cleanupKernel().

We can add a send(focusedWindow, 'menu:kill-kernel') to the quit menu item, but then you need to delay calling app.quit() to give it a chance to do stuff. What is a good way of ipc()ing and waiting for that message to have been completed. Should we send a message back via ipc and then app.quit()?

from nteract.

rgbkrk avatar rgbkrk commented on May 17, 2024

The awkward part here is the difference between OS X and all the others. cmd-q should tell each running window to close their kernel (which means ipc) or we'd have to track the kernels on the main thread to shut them down there (what if the BrowserWindow is no longer responding).

from nteract.

rgbkrk avatar rgbkrk commented on May 17, 2024

Ok, I've noticed that beforeunload and unload events are both fired when you ctrl-c kill an application, as well as the rest of the quit action. What we're definitely running into though is that we've been relying on an asynchronous flow for killing the kernel. When these two are triggered, we need to handle them immediately.

from nteract.

rgbkrk avatar rgbkrk commented on May 17, 2024

Basically we can't (and shouldn't) rely on dispatch for killing a kernel for forced lifecycle events. Otherwise our dispatched kill kernel won't happen because the reduction won't happen until the next tick.

from nteract.

lock avatar lock commented on May 17, 2024

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

from nteract.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.