Comments (10)
ah, yes
from nteract.
Safia, do this!
from nteract.
Is this the issue about kernels being alive after quitting the app?
from nteract.
Yeah our cleanup isn't fully happening right now, leaving the connection files around.
from nteract.
The process seems to keep running as well. Check pgrep -f "python3 -m ipy"
after starting and quitting nteract
a few times.
from nteract.
Pressing Cmd+q
is wired directly to app.quit()
without creating a KILL_KERNEL
action or calling cleanupKernel()
.
We can add a send(focusedWindow, 'menu:kill-kernel')
to the quit menu item, but then you need to delay calling app.quit()
to give it a chance to do stuff. What is a good way of ipc()
ing and waiting for that message to have been completed. Should we send a message back via ipc and then app.quit()
?
from nteract.
The awkward part here is the difference between OS X and all the others. cmd-q should tell each running window to close their kernel (which means ipc
) or we'd have to track the kernels on the main thread to shut them down there (what if the BrowserWindow
is no longer responding).
from nteract.
Ok, I've noticed that beforeunload
and unload
events are both fired when you ctrl-c
kill an application, as well as the rest of the quit action. What we're definitely running into though is that we've been relying on an asynchronous flow for killing the kernel. When these two are triggered, we need to handle them immediately.
from nteract.
Basically we can't (and shouldn't) rely on dispatch for killing a kernel for forced lifecycle events. Otherwise our dispatched kill kernel won't happen because the reduction won't happen until the next tick.
from nteract.
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.
from nteract.
Related Issues (20)
- Does nteract support or plan to support a extensibility/plugin model for handling output errors?
- Unable to run the nteract electron app following the steps in contribution.md HOT 2
- Last saved date appears to be incorrect
- No Python syntax highlighting in Monaco Editor 3.5.5
- Mac says: "nteract" needs to be updated
- please sign nteract mac app with apple event permission-request entitlement so that notebooks can automate other apps HOT 1
- Examples of Data Viz with Javascript in nteract notebook?
- transform-plotly is parsing input data incorrectly.
- Unable to build and run the nteract desktop app locally
- Cannot create terminal in rx-jupyter
- Cannot run any nteract application locally
- yarn install error HOT 1
- version: 3.4.12 'icons.js' does not match on disk "Icons.js"
- customize font and theme
- Issue with Saving
- Some widgets from ipywidgets v8 don't render
- Can't process Kernel Binary messages
- Cannot receive "shutdown_reply" after send "shutdown_request" HOT 1
- New desktop binaries? HOT 2
- Stuck during package installation.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nteract.