zmq for everyone about nteract HOT 20 CLOSED

@lgeiger has totally demolished this issue - from incredible cross-platform work in zmq-prebuilt, to creating zmq-static, and upstream fixes in zeromq.node.

We even have Windows builds now. 😄 😱

Closing this issue with much appreciation.

from nteract.

I recommend https://github.com/mafintosh/prebuild for the binaries part, it even has a feature to upload the binaries to GitHub Releases for you

from nteract.

Awesome. Do you think I should just create a zmq-prebuilt for now, similar to electron-prebuilt?

from nteract.

Seems like a good idea

from nteract.

Seems like I'll need Electron support in prebuild: prebuild/prebuild#61

For now I've submitted a PR to zmq relying on node-pre-gyp (JustinTulloss/zeromq.node#486), now that node-pre-gyp supports Electron directly.

from nteract.

I think this can be closed now?

from nteract.

Now that zmq-prebuilt exists (though not finished), yes!

from nteract.

Re-opening until we fully resolve this for nteract/nteract. We made a release with a built binary for some platforms, yet it requires that you still have zmq headers installed.

from nteract.

😲

from nteract.

Current pre-built status:

from nteract.

I tested zmq on windows with nteract and can manually reproduce this error.

It turns out zmq has to be built with electron headers on windows even for electron < 1.1.3 to make it work.

from nteract.

and so it is, we must trudge these waters of electron builds for the future of all of us

from nteract.

Status on windows:
Still no prebuilts for electron but working if you build from source: #903

from nteract.

@rgbkrk Since the fallback is now working in zmq-prebuilt, what should we do with zmq-static?
I think zmq-prebuilt is now superior in every way.

I didn't expect to get it working at the time of creating zmq-static 😄 .

from nteract.

Leave a deprecation notice in zmq-static, pointing to zmq-prebuilt. You apparently stirred a little bit of buzz by creating zmq-static, and if people found that over zmq-prebuilt we should at least do the service of redirecting it.

from nteract.

Great to see some people checking it out! I'll leave a notice.

from nteract.

One way to "deprecate" while being backwards compatible is to make zmq-static's index.js be:

module.exports = require('zmq-prebuilt')

(while also noting they should use zmq-prebuilt instead)

from nteract.

I think we can leave it as is for people who really want to keep using VS 2013.

from nteract.

Ah, ok, that works.

from nteract.

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

from nteract.