Code Monkey home page Code Monkey logo

Comments (8)

roman-khimov avatar roman-khimov commented on August 16, 2024
  1. In general, until we have some synchronized metadata it's OK. One node may have a tombstone object, another one may not.
  2. Still, if a node has both an object and a tombstone for it, it MUST NOT include it into the result, this needs to be checked.
  3. Script should handle this error, an appropriate error code should be returned from neofs-cli and checked for by the script.

from neofs-node.

notimetoname avatar notimetoname commented on August 16, 2024

an appropriate error code should be returned from neofs-cli

Next available for now (3)?

from neofs-node.

vvarg229 avatar vvarg229 commented on August 16, 2024

We have a falling system test test_object2_can_be_get_by_attr https://github.com/nspcc-dev/neofs-testcases/blob/master/pytest_tests/testsuites/services/http_gate/test_http_headers.py#L110

We delete an object and expect an "object already removed" error to be returned when we try to get it after the deletion. Right now it works so that we get "404 not found".

Is this expected behavior correct?

allure report:
dddd.zip

from neofs-node.

roman-khimov avatar roman-khimov commented on August 16, 2024

That's nspcc-dev/neofs-http-gw@e6e7941 and that's correct, the object can no longer be found. Previously it was "Bad Request" returned from the HTTP gate and that wasn't correct, the request is perfectly fine here.

from neofs-node.

roman-khimov avatar roman-khimov commented on August 16, 2024

Can be checked for the mainnet 2uvJyFRpcw6tKXSyypa2LSGLuF4qavL34GiutpjojkBZ container.

from neofs-node.

carpawell avatar carpawell commented on August 16, 2024

I have been looking at that bug for a while but have not found any problems. I tested mentioned contianers, look at the code but seems like it is impossible (or I need to look at this in some removal process or at the script). Added a separate code in #2526.

I guess, script may do some things fast while TS objects have not been replicated yet.

from neofs-node.

roman-khimov avatar roman-khimov commented on August 16, 2024

The way the script worked at the time of writing is:

  • iterate over uploaded files, see some img/cat.png
  • SEARCH for img/cat.png
  • DELETE that object(s)
  • PUT new object for img/cat.png

IIRC the problem happened when someone tried to run the script several times in a row before objects are really deleted. So it's certainly not some ms-range problem.

from neofs-node.

roman-khimov avatar roman-khimov commented on August 16, 2024

Considering this as fixed until proven otherwise.

from neofs-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.