Code Monkey home page Code Monkey logo

Comments (5)

TMRh20 avatar TMRh20 commented on August 22, 2024 1

Hmm, I had a feeling you'd prefer option 2 😆

I didn't realize this was fixed at the RF24 level. I guess the change isn't really required then?

from rf24mesh.

TMRh20 avatar TMRh20 commented on August 22, 2024 1

Heh, the troubling experience was always adjusting my code to set the PALevel AFTER starting the mesh and again if mesh.begin() was called, which I see is not necessary anymore.

from rf24mesh.

2bndy5 avatar 2bndy5 commented on August 22, 2024

I prefer option 2 since it is consistent with using RF24Network::begin(). There's also a deprecated RF24Network::begin(uint8_t _channel, uint16_t _node_address) which I neglected to remove when releasing v2.0. So, I think we're a bit overdue for some breaking changes.

I seem to remember a rejected PR (#210) about this that instigated changing RF24::begin() so that the PA level was not altered every time it was called. Looking at RF24::_init_radio(), I see nRF24/RF24@8ad2886 in the git blame.

from rf24mesh.

2bndy5 avatar 2bndy5 commented on August 22, 2024

I guess the change isn't really required then?

At a glance, no. Did you recently have some troubling experience that you attributed to this?

from rf24mesh.

2bndy5 avatar 2bndy5 commented on August 22, 2024

I was suspecting an ebyte module; they don't seem to respect the user-specified PA level.

from rf24mesh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.