NPM install fails when a git+ssh project is linked about cli HOT 8 CLOSED

I've run into this problem too. I have a repro here:

$ git clone [email protected]:felix9/npm-link-bug-1
$ git clone [email protected]:felix9/npm-link-bug-2
$ cd npm-link-bug-1
$ npm link
$ cd ../npm-link-bug-2
$ npm link npm-link-bug-1
$ npm install
npm ERR! Cannot read property '0' of undefined

This is where the error happens:

I'm unsure what the right fix is.

from cli.

@felix9 I think the second clone is supposed to be npm-link-bug-2 you have -1 twice.

from cli.

oops, yeah, fixed.

from cli.

Ah, fantastic, it's been nagging at me that we don't have a repro case for that npa bug.

Thanks!

from cli.

Does this mean that git hosted repos with gitRange should be avoided?

Just added one of these to my project and started noticing the error.

cat ~/.npm/_logs/2020-12-16T05_17_25_293Z-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'outdated' ]
2 info using [email protected]
3 info using [email protected]
4 verbose npm-session 695d8a0006d4fbbf
5 verbose stack TypeError: Cannot read property '0' of undefined
5 verbose stack     at npa (/usr/local/lib/node_modules/npm/node_modules/npm-package-arg/npa.js:34:25)
5 verbose stack     at doesChildVersionMatch (/usr/local/lib/node_modules/npm/lib/install/deps.js:61:22)
5 verbose stack     at versionMatch (/usr/local/lib/node_modules/npm/lib/install/deps.js:762:12)
5 verbose stack     at Array.filter (<anonymous>)
5 verbose stack     at exports.findRequirement (/usr/local/lib/node_modules/npm/lib/install/deps.js:772:23)
5 verbose stack     at findChild (/usr/local/lib/node_modules/npm/lib/install/deps.js:125:17)
5 verbose stack     at computeMetadata (/usr/local/lib/node_modules/npm/lib/install/deps.js:135:9)
5 verbose stack     at /usr/local/lib/node_modules/npm/lib/outdated.js:81:16
5 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-tree/rpt.js:162:20
6 verbose cwd ~/projects/pantheon/wellness
7 verbose Darwin 19.6.0
8 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "outdated"
9 verbose node v14.15.0
10 verbose npm  v6.14.5
11 error Cannot read property '0' of undefined
12 verbose exit [ 1, true ]

Is there a patch for const sameRepo = npa(child.package._from).fetchSpec === requested.fetchSpec that doesn't depend on the nonexistent child.packge._from value?

Edit: Duplicates #2262 #1542

from cli.

I've run into this problem too. I have a repro here:

$ git clone [email protected]:felix9/npm-link-bug-1
$ git clone [email protected]:felix9/npm-link-bug-2
$ cd npm-link-bug-1
$ npm link
$ cd ../npm-link-bug-2
$ npm link npm-link-bug-1
$ npm install
npm ERR! Cannot read property '0' of undefined

This is where the error happens:

cli/lib/install/deps.js

Lines 60 to 61 in f533d61

	if (requested.type === 'git' && requested.gitRange) {
	const sameRepo = npa(child.package._from).fetchSpec === requested.fetchSpec

The parent package is requesting a git package with a gitRange.
The child package doesn't have a _from because linked packages don't have _from, so npm calls npa(undefined)
I'm unsure what the right fix is.

How did you fix this problem?

from cli.

@VitaliyDemchuk I never found a fix or workaround, I just gave up on using npm link

from cli.

@felix9 I used this hack, but it is a very bad solution and I would like to find a more acceptable option.

from cli.