[BUG] Dependency move-file only supports node >= 10.17 about cacache HOT 8 CLOSED

So, the good news is, since cacache doesn't ever use move-file in such a way as to require making directories, so it doesn't hit the failure case. But still, it would be pretty easy to have a move-file that didn't rely on fs.promises and recursive fs.mkdir by just adding mkdirp as a dep.

from cacache.

/cc @AnthonyWC @assapir @darcyclarke @ethomson @evilpacket @gordey4doronin @hilli @isaacs @lumaxis @owenniblock @radiantspace @ruyadorno

Somebody can look at this? It is very important.

When did we start using cacache in webpack we use 15.0.0 version and guaranteed work on 10.13 node, but in 15.0.1 package migrates from move-file to move-concurrently 92b1251 without major release, but it was breaking change becaise package requires 10.17 node (https://github.com/sindresorhus/move-file/blob/master/package.json#L14). This created problems for many developers (locally and on CI). Yarn doesn't work without additional flags.

I ask you to pay attention to this problem, thanks

from cacache.

The last time we looked into fs.promises it was significantly slower than util.promisify. This is usually not a big deal for apps that only do a few fs calls, but the cli is very fs-heavy and thus those slowdowns were unacceptable.

from cacache.

/cc @isaacs

from cacache.

Yeah, the intent was to support all 10.x versions, so that's definitely an oversight on my part, sorry. I'll take a look this afternoon.

from cacache.

Sorry for commenting on an old issue, but it's probably worth dropping mkdirp now and perhaps switching to fs/promises instead of util.promisify.

from cacache.

Our current preferred way to use fs is through https://github.com/npm/fs which exports promisified versions of all methods by default, and of course has the polyfills we need for our node support matrix.

from cacache.

Thanks for the explanation! It might be worth switching to that then for all fs methods instead of util.promisify and mkdirp.

from cacache.