Code Monkey home page Code Monkey logo

Comments (3)

novoid avatar novoid commented on May 29, 2024

An up to date version should be available via https://github.com/novoid/Memacs/blob/master/setup.py

from memacs.

sanzoghenzo avatar sanzoghenzo commented on May 29, 2024

Hi @novoid, great project!
I still have to install it, but I'm planning to do it ASAP.
My thoughts from what I've learned in ~5 years of python:

  • requirements.txt are good for developers, especially if version are pinned, to reproduce the exact dev environment (or for docker based CI to exploit caching). For a good user experience pip install memacs (if you plan to publish it on pipy) or cloning the repo and doing pip install . is the "right" way, IMO. That means dependencies have to be declared in setup.py or setup.cfg (or pyproject.toml if using poetry - it looks very promising)

  • I've seen that in your latest setup.py the entry_point is commented. This is the way to go, and as stated here,

    [each entry point] can optionally specify “extras” that it depends on, that will be added to sys.path when the script is run.

    Then later on the dynamic discovery section

    It can also include a bracketed list of “extras” that are required for the entry point to be used.

    This goes hand in hand with #74: you specify the "extras" in extras_require and use them in the entry_points declaration.

  • I'm in favor of Semantic versioning, a widely accepted system for versioning a project. It's the default of npm packages, and many python packages also use this. In a nutshell:

    • the syntax is major.minor.bugfix
    • bugfix is incremented when, well, a bug is fixed
    • minor is incremented for edits or new feature that don't break the API (backward compatible)
    • major is incremented for edits that changes the API, so backward compatibility is not granted.

    I like to use it in conjunction with commitizen and conventional commits, so that version are bumped by parsing the commits messages, and you can also automate it with Actions.

from memacs.

novoid avatar novoid commented on May 29, 2024

Thanks @sanzoghenzo for your comments!

Unfortunately, my personal pressure is not as high as it should be to distribute memacs via pip since I'm using the sources directly. On the other hand, I'm not sure if the current status should be published via pip because it would require many dependencies considering the wide range of modules. #96 fixed on of the issues by introducing appropriate links for the modules.

Semantic versioning: I understand the advantages and for most larger projects, this makes perfectly sense to me as well. However, in small projects, there are no bugfix releases and I do not differ between minor and major releases.

Instead, the information of the date seems much more interesting than any artificial number like 0.4.7 which does not hold any valuable information without a relation to a second version number. This is why I tend not to use semantic versioning for now.

If the modules are separated from the main framework, semantic versioning would be much more interesting and probably also a must-have since the separated modules would have to rely on a compatible framework with non-breaking changes for minor releases and potentially breaking changes only for major releases.

from memacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.