websockify.py not forwarding data just before connection close about websockify HOT 6 CLOSED

The C version does not have this problem

from websockify.

Sounds a lot like the issue I raised (#36), but with better documentation. :)

Good to know the C version doesn't appear to have the problem, but I haven't had a chance to work on the large message issue there, so a Python fix would be most welcome!

from websockify.

Oh, I guess I was too eager to report there. I'll just keep this open until kanaka sees it. This one can be closed afterwards, of course, I'm pretty sure that this is a duplicate.

from websockify.

Thank you for the test case. That made my life much simpler. And sorry for the slow reply.

Try 5e16b38. It should at least address your test case. I moved the client socket handling earlier in the loop. The problem with the current situation is that if the target immediately closes after sending the data (which seems to happen sporadically even with the sleep), then the data will never be sent to the client because the next time through the loop it will read from the target, detect that it is closed and never reach the client socket handling.

Please also try in the full case where you are seeing the problem. There is still a possible problem where the client socket is busy and so not all the data from the target gets sent, but this is a theoretical possibility and complicates the code so unless people are actually running into I'm hoping this trivial re-ordering will solve what you are actually seeing.

from websockify.

@kanaka : The problem is fixed. The affected test was emscripten/src/runner.py/test_zz_websockets.

from websockify.

Great! Thanks for verifying.

from websockify.