BaseChannel/GetBytes, buffer overrun potential about agent.contrib HOT 6 OPEN

Yes, this stuff is definitely a work in progress! The whole Channel/Communication setup needs to be ironed out completely and tested fully....

from agent.contrib.

I'd also push the buffer out to the class level and preallocate it, for performance. Less GC and frag.

from agent.contrib.

Why close the issue if the code is still fragile/incomplete?

from agent.contrib.

Hit the wrong button.. :p

from agent.contrib.

This should do it...

    protected byte[] GetBytes(SerialPort port)
    {
        byte[] buffer = new byte[port.BytesToRead];
        port.Read(buffer, 0, buffer.Length);
        return buffer;
    }

seems simple enough..

what do you think?

from agent.contrib.

Could run out of memory quickly. Think 57.6k for example, 1+ seconds. Otherwise it is simply correct.
In my testing on the emulator, despite either timer polling or DataReceived, sometimes a stall occurred for a few seconds.
No doubt with an OS the AGENT may too.
Safer to use a limit, allowing User to tweak it.

Sent from my Kindle Fire

From: Rob Chartier [email protected]
Sent: Fri Jul 12 22:57:50 CST 2013
To: "nothingmn/AGENT.Contrib" [email protected]
Cc: Chris Meier [email protected]
Subject: Re: [AGENT.Contrib] BaseChannel/GetBytes, buffer overrun potential (#9)

This should do it...

protected byte[] GetBytes(SerialPort port) { byte[] buffer = new byte[port.BytesToRead]; port.Read(buffer, 0, buffer.Length); return buffer; }

seems simple enough..

what do you think?

—
Reply to this email directly or view it on GitHub.

from agent.contrib.