Code Monkey home page Code Monkey logo

Comments (9)

fabiospampinato avatar fabiospampinato commented on May 21, 2024 4

Implemented, will be available in the next release.

Thank you @tylerdiaz for submitting the PR. I've made some changes to your implementation (2a8c7b2):

  • regexes aren't actually that bad performance-wise
  • searching in the content first is better for performance
  • searching the entire content of the note, including metadata, enables a more powerful search engine
  • each word is matched against individually, combining with the the previous point this means that we can find all notes with attachments just by typing "attachments", we can also find all notes in a notebook matching a word "notebooks/foo word" etc. much better than before.

from notable.

openstep avatar openstep commented on May 21, 2024 3

from notable.

millsoft avatar millsoft commented on May 21, 2024 1

just installed Notable, really cool app. But the search inside notes is the most used feature I use in Evernote. I could search in terminal using grep but it would be nice to be able to do this in Notable.

from notable.

openstep avatar openstep commented on May 21, 2024 1

Hi,

Could you please highlight the search results on the notes so that it is possible to find the search results inside the notes.

Thanks

from notable.

fabiospampinato avatar fabiospampinato commented on May 21, 2024

Yes this should be implemented.

It gets tricky though as fuzzy match will probably return too many matches if the content is search into as well. Maybe the notes should be properly indexes in that case and a regular search would suffice.

from notable.

corwinou avatar corwinou commented on May 21, 2024

I just discovered your app and indeed coming from Evernote. Looks amazing, but as a basic feature, I also think it really needs to search inside notes !

from notable.

fabiospampinato avatar fabiospampinato commented on May 21, 2024

@openstep #243 and #244

from notable.

openstep avatar openstep commented on May 21, 2024

So is that mean this idea will not be implemented or it will be?
"Feature Request: Search inside notes rather than just on note titles #48" closed
I do not get it.

from notable.

fabiospampinato avatar fabiospampinato commented on May 21, 2024

So is that mean this idea will not be implemented or it will be?

Most probably.

I do not get it.

This is a duplicate issue, we are tracking what you requested in the issues I linked you.

from notable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.